Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main -> 2.2] ci: Bump marocchino/sticky-pull-request-comment action to latest version (2.9.0) #22262

Merged
merged 14 commits into from
Aug 19, 2024

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Aug 19, 2024

Cherry-pick of #22259 and #22264 to the 2.2 release branch.

Updates the marocchino/sticky-pull-request-comment action to its latest version, 2.9.0. This upgrade was needed because some options used in recent workflows are not available in the older version.

I confirmed that the commit 331f8f5b4215f0445d3c07b4967662a32a2d3e31 corresponds to the v2.9.0 tag in the
marocchino/sticky-pull-request-comment repo:
https://github.com/marocchino/sticky-pull-request-comment/releases/tag/v2.9.0

I also updated the triggering event to pull_request_target from pull_request.

…ion (2.9.0) (microsoft#22259)

Updates the marocchino/sticky-pull-request-comment action to its latest
version, 2.9.0. This upgrade was needed because some options used in
recent workflows are not available in the older version.

I confirmed that the commit 331f8f5b4215f0445d3c07b4967662a32a2d3e31
corresponds to the v2.9.0 tag in the
marocchino/sticky-pull-request-comment repo:
https://github.com/marocchino/sticky-pull-request-comment/releases/tag/v2.9.0

This will be ported to the 2.2 release branch as well.
@github-actions github-actions bot added area: build Build related issues base: release PRs targeted against a release branch labels Aug 19, 2024
@tylerbutler tylerbutler changed the title ci: Bump marocchino/sticky-pull-request-comment action to latest version (2.9.0) [main > 2.2] ci: Bump marocchino/sticky-pull-request-comment action to latest version (2.9.0) Aug 19, 2024
@tylerbutler tylerbutler changed the title [main > 2.2] ci: Bump marocchino/sticky-pull-request-comment action to latest version (2.9.0) [main -> 2.2] ci: Bump marocchino/sticky-pull-request-comment action to latest version (2.9.0) Aug 19, 2024
CraigMacomber
CraigMacomber previously approved these changes Aug 19, 2024
@tylerbutler tylerbutler changed the base branch from release/client/2.2 to main August 19, 2024 21:13
@tylerbutler tylerbutler changed the base branch from main to release/client/2.2 August 19, 2024 21:13
@tylerbutler tylerbutler dismissed CraigMacomber’s stale review August 19, 2024 21:13

The base branch was changed.

…soft#22264)

The release branch warning workflow needs to use the pull_request_target
trigger instead of the pull_request trigger, so it can post to the PR.

This is safe because the PR does not build anything or use content from
the submitted PR. When using pull_request_target the checked-out code is
the base branch, not the PR branch, so there's no access to content from
the PR itself.
@tylerbutler
Copy link
Member Author

Merging because this is an infrastructure change and doesn't imply a release.

@tylerbutler tylerbutler merged commit 2e0530b into microsoft:release/client/2.2 Aug 19, 2024
28 checks passed
@tylerbutler tylerbutler deleted the ci-comments-22 branch August 19, 2024 22:39
Copy link
Contributor

Warning

WARNING: This PR is targeting a release branch!

All changes must first be merged into main and then backported to the target release branch.
Please include a link to the main PR in the description of this PR.

Changes to release branches require approval from the Patch Triage group before merging.
You should have already discussed this change with them so they know to expect it.

For more details, see our internal documentation for the patch policy and processes for
patch releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: release PRs targeted against a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants