Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/remove i segment deprecations #22696

Draft
wants to merge 32 commits into
base: test/internal-merge-tree-client
Choose a base branch
from
Draft

Test/remove i segment deprecations #22696

wants to merge 32 commits into from

Conversation

anthony-murphy
Copy link
Contributor

@anthony-murphy anthony-murphy commented Oct 1, 2024 •
edited
Loading

in progress

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels Oct 1, 2024
@anthony-murphy anthony-murphy force-pushed the test/remove-ISegment-deprecations branch from f3815f4 to fb201de Compare October 2, 2024 18:55
@github-actions github-actions bot added the area: build Build related issues label Oct 2, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 2, 2024 •
edited
Loading

⯆ @fluid-example/bundle-size-tests: -703 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.31 KB 459.99 KB ⯆ -324 Bytes
azureClient.js 557.29 KB 557.34 KB ⯅ +49 Bytes
connectionState.js 724 Bytes 724 Bytes ■ No change
containerRuntime.js 259.58 KB 259.6 KB ⯅ +14 Bytes
fluidFramework.js 405.95 KB 405.96 KB ⯅ +14 Bytes
loader.js 134.34 KB 134.36 KB ⯅ +14 Bytes
map.js 42.46 KB 42.46 KB ⯅ +7 Bytes
matrix.js 148.63 KB 148.4 KB ⯆ -233 Bytes
odspClient.js 524.25 KB 524.3 KB ⯅ +49 Bytes
odspDriver.js 97.84 KB 97.86 KB ⯅ +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB ⯅ +14 Bytes
sharedString.js 164.82 KB 164.49 KB ⯆ -342 Bytes
sharedTree.js 396.41 KB 396.41 KB ⯅ +7 Bytes
Total Size 3.31 MB 3.31 MB ⯆ -703 Bytes

Baseline commit: f57799c

Generated by 🚫 dangerJS against cb1c19f

@anthony-murphy anthony-murphy reopened this Oct 7, 2024
@anthony-murphy anthony-murphy changed the base branch from main to test/internal-merge-tree-client October 8, 2024 19:26
anthony-murphy
anthony-murphy commented Oct 8, 2024
View reviewed changes
packages/dds/merge-tree/package.json Outdated
@@ -175,6 +175,7 @@
"typescript": "~5.4.5"
},
"typeValidation": {
"disabled": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting to update closer until this can be merged

anthony-murphy
anthony-murphy commented Oct 8, 2024
View reviewed changes
tools/pipelines/build-client.yml
@@ -58,6 +58,7 @@ trigger:
- next
- lts
- release/*
- test/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pr into another test branch for now, so this lets the pr build run

@anthony-murphy
Copy link
Contributor Author

#22828 #22829

@anthony-murphy anthony-murphy mentioned this pull request Oct 31, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

Stats:
  440694 links
    3397 destination URLs
       2 URLs ignored
       0 warnings
       0 errors

jason-ha
jason-ha reviewed Nov 1, 2024
View reviewed changes
packages/dds/merge-tree/src/localReference.ts
@@ -226,11 +222,10 @@ export function setValidateRefCount(
* Represents a collection of {@link LocalReferencePosition}s associated with one segment in a merge-tree.
* @sealed
*
* @legacy
* @alpha
* @internal
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-deprecated class is being removed from legacy API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-ha jason-ha jason-ha left review comments

Assignees
No one assigned
Labels
area: build Build related issues area: dds: sharedstring area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthony-murphy @msfluid-bot @jason-ha