-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove WRITE usages of compatDetails on ContainerRuntime GC ops #22795
Open
MarioJGMsoft
wants to merge
9
commits into
microsoft:main
Choose a base branch
from
MarioJGMsoft:compatDetailsGCRemoval
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
Runtime related issues
base: main
PRs targeted against main branch
labels
Oct 14, 2024
⯆ @fluid-example/bundle-size-tests: -283 Bytes
Baseline commit: a390d2f |
github-actions
bot
added
the
area: tests
Tests to add, test infrastructure improvements, etc
label
Oct 15, 2024
MarioJGMsoft
changed the title
Removed Compat details from GC
Remove WRITE usages of compatDetails on ContainerRuntime GC ops
Oct 15, 2024
MarioJGMsoft
requested review from
agarwal-navin,
a team,
pragya91,
markfields,
jatgarg,
tyler-cai-microsoft,
kian-thompson and
rajatch-ff
and removed request for
a team
October 15, 2024 22:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: AB#19718
Follow-on to #17024
We need to look at Kusto first to confirm our theory that the code to read both the GC op types ("Sweep" and "TombstoneLoaded") has sufficiently saturated.
"Sweep" was added in 2.0.0-internal.7.4.0
"TombstoneLoaded" was added in 2.0.0-rc.2.0.0
We do see sessions on RC.1, but I believe they're all Whiteboard, which doesn't see any "TombstoneLoaded" events which trigger those ops.
We can write a query to confirm with high confidence, then proceed.
Reviewer Guidance
The goal of this PR is to remove all uses of compatDetails that are no longer necessary, please let me know if I missed any or if there are some that can't be removed yet.