Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WRITE usages of compatDetails on ContainerRuntime GC ops #22795

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MarioJGMsoft
Copy link
Contributor

@MarioJGMsoft MarioJGMsoft commented Oct 14, 2024

Description

Fixes: AB#19718

Follow-on to #17024

We need to look at Kusto first to confirm our theory that the code to read both the GC op types ("Sweep" and "TombstoneLoaded") has sufficiently saturated.
"Sweep" was added in 2.0.0-internal.7.4.0
"TombstoneLoaded" was added in 2.0.0-rc.2.0.0
We do see sessions on RC.1, but I believe they're all Whiteboard, which doesn't see any "TombstoneLoaded" events which trigger those ops.

We can write a query to confirm with high confidence, then proceed.

Reviewer Guidance

The goal of this PR is to remove all uses of compatDetails that are no longer necessary, please let me know if I missed any or if there are some that can't be removed yet.

@github-actions github-actions bot added area: runtime Runtime related issues base: main PRs targeted against main branch labels Oct 14, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 15, 2024

@fluid-example/bundle-size-tests: -283 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 459.8 KB 459.71 KB -97 Bytes
azureClient.js 557.02 KB 556.94 KB -83 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.42 KB 259.3 KB -118 Bytes
fluidFramework.js 405.81 KB 405.82 KB +14 Bytes
loader.js 134.24 KB 134.25 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.29 KB 148.29 KB +7 Bytes
odspClient.js 523.98 KB 523.9 KB -83 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.48 KB 164.49 KB +7 Bytes
sharedTree.js 396.27 KB 396.28 KB +7 Bytes
Total Size 3.31 MB 3.31 MB -283 Bytes

Baseline commit: a390d2f

Generated by 🚫 dangerJS against 716467d

@github-actions github-actions bot added the area: tests Tests to add, test infrastructure improvements, etc label Oct 15, 2024
@MarioJGMsoft MarioJGMsoft changed the title Removed Compat details from GC Remove WRITE usages of compatDetails on ContainerRuntime GC ops Oct 15, 2024
@MarioJGMsoft MarioJGMsoft marked this pull request as ready for review October 15, 2024 22:42
@MarioJGMsoft MarioJGMsoft requested review from agarwal-navin, a team, pragya91, markfields, jatgarg, tyler-cai-microsoft, kian-thompson and rajatch-ff and removed request for a team October 15, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants