Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code for Audience population from snapshot #22801

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

WillieHabi
Copy link
Contributor

@WillieHabi WillieHabi commented Oct 14, 2024

Description

In protocol handler, we have duplicate for loops that populates Audience from Quorum members (lines 67-69 already do this). This PR deletes the duplicate code.

@github-actions github-actions bot added base: main PRs targeted against main branch area: loader Loader related issues labels Oct 14, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +11 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 459.57 KB 459.61 KB +35 Bytes
azureClient.js 556.79 KB 556.76 KB -29 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.19 KB 259.2 KB +14 Bytes
fluidFramework.js 405.81 KB 405.82 KB +14 Bytes
loader.js 134.24 KB 134.18 KB -64 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.29 KB 148.29 KB +7 Bytes
odspClient.js 523.75 KB 523.73 KB -29 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.48 KB 164.49 KB +7 Bytes
sharedTree.js 396.27 KB 396.28 KB +7 Bytes
Total Size 3.31 MB 3.31 MB +11 Bytes

Baseline commit: fcd15e0

Generated by 🚫 dangerJS against d480275

@WillieHabi WillieHabi marked this pull request as ready for review October 15, 2024 16:08
@ChumpChief
Copy link
Contributor

Agree this looks duplicate and safe to remove, but then again it was duplicated explicitly in #20766 - maybe check with @vladsud if there's something we're missing here, e.g. if there's some weird interaction with external ProtocolOpHandlers?

@jason-ha
Copy link
Contributor

Agree this looks duplicate and safe to remove, but then again it was duplicated explicitly in #20766 - maybe check with @vladsud if there's something we're missing here, e.g. if there's some weird interaction with external ProtocolOpHandlers?

I second double checking this. There was also a test added when the apparent duplicate code was added. I can't see why ordering would matter. Very curious.

@WillieHabi WillieHabi merged commit 6e55c5a into microsoft:main Oct 16, 2024
34 of 35 checks passed
@WillieHabi WillieHabi deleted the populate-audience branch October 24, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: loader Loader related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants