-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add socker error handling for r11s #22864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↓ packages.drivers.routerlicious-driver.src:
Line Coverage Change: -3.92% Branch Coverage Change: -8.74%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 83.40% | 74.66% | ↓ -8.74% |
Line Coverage | 58.25% | 54.33% | ↓ -3.92% |
Baseline commit: 55bed2d
Baseline build: 302815
Happy Coding!!
Code coverage comparison check failed!!
More Details: Readme
- Skip This Check!!
What to do if the code coverage check fails:
-
Ideally, add more tests to increase the code coverage for the package(s) whose code-coverage regressed.
-
If a regression is causing the build to fail and is due to removal of tests, removal of code with lots of tests or any other valid reason, there is a checkbox further up in this comment that determines if the code coverage check should fail the build or not. You can check the box and trigger the build again. The test coverage analysis will still be done, but it will not fail the build if a regression is detected.
-
Unchecking the checkbox and triggering another build should go back to failing the build if a test-coverage regression is detected.
-
You can check which lines are covered or not covered by your tests with these steps:
- Go to the PR ADO build.
- Click on the link to see its published artifacts. You will see an artifact named
codeCoverageAnalysis
, which you can expand to reach to a particular source file's coverage html which will show which lines are covered/not covered by your tests. - You can also run different kind of tests locally with
:coverage
tests commands to find out the coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple testing comments
packages/drivers/routerlicious-driver/src/test/r11sSocketTests.spec.ts
Outdated
Show resolved
Hide resolved
packages/drivers/routerlicious-driver/src/test/r11sSocketTests.spec.ts
Outdated
Show resolved
Hide resolved
Skipping the check since, the decrease is due to the removal of mocha:esm version tests because of mocks are not permitted there and we run same test with mocha:cjs. |
⯅ @fluid-example/bundle-size-tests: +691 Bytes
Baseline commit: 55bed2d |
Description
AB#18937
Implement error handling for the following errors sent by AFR over the socket.
1.) For Cluster Draining:
error = {
code: 503,
canRetry?: true;
message?: "Cluster is not available. Please retry later.";
retryAfter?: number;
retryAfterMs?: number;
internalErrorCode?:ClusterDraining;
}
2.) Token Revoked:
error = {
code: 401/403,
canRetry?: false;
message?: "Permission denied. Token has been revoked.";
internalErrorCode?:TokenRevoked;
}