Add driver type information in service-client telemetry #22951

sonalideshpandemsft · 2024-10-31T18:34:31Z

This change adds driver, driverEndpointName and testVariant information to service-client telemetry. Rest of the field such as clientType, loaderId and containerId are not displayed as part of Test_start and Test_end event name

ADO Work Item

Updates website build to no longer dynamically generate `fallback/index.js`. Instead, the redirects are hard-coded in `fallback/routes.js`. This work is in preparation for the Docusaurus migration. [AB#19990](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/19990)

msfluid-bot

Code Coverage Summary

↑ packages.dds.tree.src.simple-tree:
Line Coverage Change: No change Branch Coverage Change: 0.01%

Metric Name	Baseline coverage	PR coverage	Coverage Diff
Branch Coverage	93.33%	93.34%	↑ 0.01%
Line Coverage	97.10%	97.10%	→ No change

↑ packages.dds.tree.src.shared-tree:
Line Coverage Change: No change Branch Coverage Change: 0.03%

Metric Name	Baseline coverage	PR coverage	Coverage Diff
Branch Coverage	91.34%	91.37%	↑ 0.03%
Line Coverage	97.44%	97.44%	→ No change

↑ packages.dds.tree.src.simple-tree.api:
Line Coverage Change: No change Branch Coverage Change: 0.04%

Metric Name	Baseline coverage	PR coverage	Coverage Diff
Branch Coverage	86.49%	86.53%	↑ 0.04%
Line Coverage	81.77%	81.77%	→ No change

Baseline commit: e432720
Baseline build: 303572
Happy Coding!!

Code coverage comparison check passed!!

…idFramework into test/log-data

## Description Adjusts the `condition` parameter of `include-conditionally-run-stress-test` to apply to the entire stage rather than the test-running job. This improves the clarity from the pipeline overview page, see most recent run vs previous ones: ![image](https://github.com/user-attachments/assets/e344d02a-a617-4163-bbda-0bfaac276541) This also fixes the `stressMode` parameter not being given options at queue time, which was introduced in microsoft#21702 and prevented the pipeline from being queued. --------- Co-authored-by: Abram Sanderson <[email protected]>

…ments (microsoft#22946) ## Description See changeset for details.

…ched tree (microsoft#22947) ## Description It is possible to load a summary into a detached SharedTree. In this case, the detached revision that is used to generate sequence IDs for commits while detached must be updated to ensure that it doesn't duplicate any of the sequence IDs already used in the summary. This PR fixes the issue and also adds an assert when sequencing in the EditManager to ensure that we don't sequence regressive sequence IDs. This fix also allows us to trim the trunk when summarizing (without breaking our fuzz tests), which reduces summary sizes especially for detached trees with many synchronous edits.

Abe27342 · 2024-10-31T22:54:22Z

packages/service-clients/end-to-end-tests/azure-client/src/test/.mocharc.cjs

+	const testVariant = getFluidTestVariant();
+	process.env.FLUID_TEST_VARIANT = testVariant;
+
+	return config(packageDir, additionalRequiredModules, testVariant);


this looks wrong, seems like you want getFluidTestMochaConfig(packageDir, additionalRequiredModules, testVariant) here. Same in other mocharc

thanks for catching that!

Abe27342 · 2024-10-31T22:58:05Z

packages/service-clients/end-to-end-tests/odsp-client/package.json

@@ -30,7 +30,7 @@
 		"test": "npm run test:realsvc:odsp:run",
 		"test:coverage": "c8 npm test",
 		"test:realsvc:odsp": "cross-env npm run test:realsvc:odsp:run",
-		"test:realsvc:odsp:run": "mocha --recursive \"lib/test/**/*.spec.*js\" --exit --timeout 20000",
+		"test:realsvc:odsp:run": "mocha --recursive \"lib/test/**/*.spec.*js\" --exit --timeout 20000 --config src/test/.mocharc.cjs -- --driver=odsp --driverEndpoint=odsp",


Is there a reason for the -- (i.e. not passing --driver=odsp directly to mocha)?

AFAIK that syntax is mostly just a thing for npm, where generally speaking, command-line arguments to npm are not plumbed through to child processes it creates. So e.g. npm run foo --someFlag runs the script foo and passes someFlag to the npm process, but whatever code executes as a result of running the foo script won't see --someFlag in its arguments. However npm run foo -- --someFlag is the opposite: the npm process doesn't have --someFlag but the script for foo will.

…oft#22953) ## Description Make SchematizingSimpleTreeView implement TreeViewAlpha, and add some helper types.

…2954) previous shouldDeploy condition have not been included in deployment condition. This variable has been updated to "forceDeployment" and included back in the deployment condition. shouldDeploy has been updated to check if release builds are the latest version in its major version series.

…g-data

…idFramework into log-data

github-actions · 2024-11-01T05:44:10Z

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

http://localhost:1313/docs/start/quick-start/
- (3422:4) 'Node.js' => https://nodejs.org/en/download (connection failed)


Stats:
  440694 links
    3397 destination URLs
       2 URLs ignored
       1 warnings
       1 errors

 ELIFECYCLE  Command failed with exit code 1.

github-actions bot added the base: main PRs targeted against main branch label Oct 31, 2024

log data

bd89d96

sonalideshpandemsft force-pushed the log-data branch from dfdc9c5 to bd89d96 Compare October 31, 2024 18:37

msfluid-bot reviewed Oct 31, 2024

View reviewed changes

sonalideshpandemsft and others added 4 commits October 31, 2024 19:27

Merge branch 'log-data' of https://github.com/sonalideshpandemsft/Flu…

df151ba

…idFramework into test/log-data

Tree: allow explicit construction of array and map nodes with no argu…

176335c

…ments (microsoft#22946) ## Description See changeset for details.

Abe27342 reviewed Oct 31, 2024

View reviewed changes

sonalideshpandemsft and others added 7 commits October 31, 2024 23:02

Correct function name

efdc7b0

tree: Make SchematizingSimpleTreeView implement TreeViewAlpha (micros…

512e53f

…oft#22953) ## Description Make SchematizingSimpleTreeView implement TreeViewAlpha, and add some helper types.

fix function

74e26b4

Fix mocharc

87ab4bf

Merge branch 'test/log-data', remote-tracking branch 'origin' into lo…

1aa71f9

…g-data

Merge branch 'log-data' of https://github.com/sonalideshpandemsft/Flu…

cd443db

…idFramework into log-data

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add driver type information in service-client telemetry #22951

Add driver type information in service-client telemetry #22951

sonalideshpandemsft commented Oct 31, 2024

msfluid-bot left a comment •

edited

Loading

Abe27342 Oct 31, 2024

sonalideshpandemsft Oct 31, 2024

Abe27342 Oct 31, 2024

github-actions bot commented Nov 1, 2024

Add driver type information in service-client telemetry #22951

Are you sure you want to change the base?

Add driver type information in service-client telemetry #22951

Conversation

sonalideshpandemsft commented Oct 31, 2024

msfluid-bot left a comment • edited Loading

Choose a reason for hiding this comment

Code Coverage Summary

Code coverage comparison check passed!!

Abe27342 Oct 31, 2024

Choose a reason for hiding this comment

sonalideshpandemsft Oct 31, 2024

Choose a reason for hiding this comment

Abe27342 Oct 31, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 1, 2024

linkcheck output

msfluid-bot left a comment •

edited

Loading