Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DS comms #50

Open
wants to merge 1 commit into
base: main_before_rebase
Choose a base branch
from

Conversation

Quentin-Anthony
Copy link

@Quentin-Anthony Quentin-Anthony commented Jun 13, 2022

@awan-10 -- FYI

DeepSpeed no longer directly calls torch.distributed microsoft/DeepSpeed#1985. This commit updates Megatron-DeepSpeed to adhere to the new deepspeed.comm interface.

@Quentin-Anthony
Copy link
Author

One thing I'm uncertain about is whether we should wrap calls in checks to whether args.deepspeed is set like in: https://github.com/microsoft/Megatron-DeepSpeed/blob/main/megatron/training.py#L114

E.g.

if args.deepspeed:
    deepspeed.comm.get_rank()
else:
    torch.distributed.get_rank()

However, this would require that args be propagated to all files where comms are used, which may get a bit messy. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant