Fix typos #290
Merged
Fix typos #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Jan 24, 2024
* add bitwise AND example (microsoft#289) * add bitwise AND example * fix cargo clippy * Fix typos (microsoft#290) * fix typo * fix typo * Fix typo * Remove absorbing of running instance (microsoft#291) * Remove absorbing of running instance * Update value of NUM_FE_FOR_RO * Update expected values in tests * Add comment * cargo fmt * relax requirements on the size of public IO and add a note about NIFS (microsoft#294) * relax requirements on the size of public IO * add a note --------- Co-authored-by: Srinath Setty <[email protected]> Co-authored-by: GoodDaisy <[email protected]> Co-authored-by: Varun Thakore <[email protected]>
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Feb 14, 2024
* refactor: remove unneeded MSM from IPA - Added new trait usage and extended `AffineExt` with more bounds in `src/provider/traits.rs` to enable greater functionality. - new bounds on AffineExt are trivially satisfied and parrot existing ones, they are repeated to work around the lack of associated_type_bounds - Optimized vector processing in the `fold` method of `src/provider/pedersen.rs`. Element-wise vector addition replaced the previous multiscalar multiplication method. * chore: remove unneeded trait bounds * chore: some simplifications * refactor: Optimize commitment key handling and IPA - Transitioned variable ck and ck_c to mutable to facilitate in-place operations. - Optimized the `split_at` function in `Pedersen.rs` using the `split_off` method. - Reconfigured the `combine` function to clone and chain iterables for expedited vector creation. - Reassessed the `scale` function to in-place operations, eliminating the need for new struct instances. - Streamlined code in `scale` and `fold` functions by removing superfluous variable assignments. * refactor: test going back to MSM in fold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.