Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make r1cs compoents public #306

Conversation

RyanKung
Copy link
Contributor

@RyanKung RyanKung commented Feb 5, 2024

For now, mod r1cs and it's components are private, this PR aims to make them public, thus can be used outside nova repo.

@RyanKung
Copy link
Contributor Author

RyanKung commented Feb 5, 2024

@microsoft-github-policy-service agree [company="{Rings Network}"]

@RyanKung
Copy link
Contributor Author

RyanKung commented Feb 5, 2024

@microsoft-github-policy-service agree company="rings network"

@srinathsetty
Copy link
Collaborator

Hi @RyanKung Could you clarify the need to use R1CS-related types through Nova's APIs?

A key principle in Nova is to minimize public APIs so users of Nova work with a simple API. In that vein, the R1CS module is expected to be internal-only types. So, can you please clarify your use case?

@RyanKung
Copy link
Contributor Author

RyanKung commented Feb 7, 2024

Hi @RyanKung Could you clarify the need to use R1CS-related types through Nova's APIs?

A key principle in Nova is to minimize public APIs so users of Nova work with a simple API. In that vein, the R1CS module is expected to be internal-only types. So, can you please clarify your use case?

I hope to implement my own fold algorithm externally, so I hope Nova's private modules can have appropriate permissions. If this does not align with Nova's design purpose, it's OK to close this PR.

@srinathsetty
Copy link
Collaborator

Hi @RyanKung Could you clarify the need to use R1CS-related types through Nova's APIs?
A key principle in Nova is to minimize public APIs so users of Nova work with a simple API. In that vein, the R1CS module is expected to be internal-only types. So, can you please clarify your use case?

I hope to implement my own fold algorithm externally, so I hope Nova's private modules can have appropriate permissions. If this does not align with Nova's design purpose, it's OK to close this PR.

Even if we make r1cs module public, it is not clear it will help you build your own folding scheme. The repo is not parameterized by the folding scheme yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants