Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize vectorized bitset::to_string implementation #5013

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlexGuteniev
Copy link
Contributor

Not an optimization, rather maintenance change.

Experience with bitset from string and others has shown that while traits-based approach is a bit harder to read, it is less error prone.

The benchmark results are within the same.

The only semantic change is that now memcpy is always used for tail, instead of just one specific case where tail can be long.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner October 13, 2024 13:51
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Oct 13, 2024
@StephanTLavavej StephanTLavavej changed the title Generalize vectorized bitset::to_string implementation Generalize vectorized bitset::to_string implementation Oct 14, 2024
@StephanTLavavej StephanTLavavej self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Status: Initial Review
Development

Successfully merging this pull request may close these issues.

3 participants