migrate to node20

microsoft · Aug 18, 2023 · 9dc04b8 · 9dc04b8
1 parent 44e727d
commit 9dc04b8
Show file tree

Hide file tree

Showing 11 changed files with 836 additions and 375 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -6,7 +6,7 @@ trigger:
 variables:
   - group: npm-tokens
   - name: nodeVersion
-    value: '16.13.0'
+    value: '20.3.1'
 
 jobs:
 #################################################

diff --git a/node/buildutils.js b/node/buildutils.js
@@ -35,7 +35,7 @@ exports.getExternals = function () {
     // and add node to the PATH
     var nodeUrl = process.env['TASK_NODE_URL'] || 'https://nodejs.org/dist';
     nodeUrl = nodeUrl.replace(/\/$/, '');  // ensure there is no trailing slash on the base URL
-    var nodeVersion = 'v16.13.0';
+    var nodeVersion = 'v20.3.1';
     switch (platform) {
         case 'darwin':
             var nodeArchivePath = downloadArchive(nodeUrl + '/' + nodeVersion + '/node-' + nodeVersion + '-darwin-x64.tar.gz');

diff --git a/node/docs/minagent.md b/node/docs/minagent.md
@@ -30,6 +30,8 @@ Use the details below to determine when specific agent features were added:
   - Added in 2.144.0. Used node v10.x
 * `node16` handler
   - Added in 2.206.1. Used node v16.x
+* `node20` handler
+  - Added in 2.225.0. Used node v20.x
 * `powershell3` handler
   - Added in 1.95.1
   - Updated in 1.97 to propagate `Data` property for endpoints

diff --git a/node/docs/nodeEnvironment.md b/node/docs/nodeEnvironment.md
@@ -22,6 +22,15 @@ With agent version 2.206.1 Node 16 can be used.
 },
 ```
 
+With agent version 2.225.0 Node 20 can be used.
+
+```
+"execution": {
+    "Node20": {
+        "target": "path/to/entry"
+    }
+},
+```
 Existing `Node` execution targets will still resolve to a Node 6 environment for now to maintain back-compat.
 
 ### Testing your task

diff --git a/node/docs/nodeVersioning.md b/node/docs/nodeVersioning.md
@@ -2,9 +2,9 @@
 
 ## Agent Node Handler
 
-The agent currently has 3 different node handlers that it can use to execute node tasks: Node 6, Node 10, Node 16.
+The agent currently has 4 different node handlers that it can use to execute node tasks: Node 6, Node 10, Node 16, and Node20.
 The handler used depends on the `execution` property specified in the tasks `task.json`.
-If the `execution` property is specified to be `Node`, the task will run on the Node 6 handler, for `Node10` it will run on the Node 10 handler, for `Node16` it will run on the Node 16 handler.
+If the `execution` property is specified to be `Node`, the task will run on the Node 6 handler, for `Node10` it will run on the Node 10 handler, for `Node16` it will run on the Node 16 handler, for `Node20` it will run on the Node 20 handler.
 
 ## Mock-test Node Handler
 

diff --git a/node/mock-test.ts b/node/mock-test.ts
@@ -152,8 +152,11 @@ export class MockTestRunner {
             case 16:
                 downloadVersion = 'v16.13.0';
                 break;
+            case 20:
+                downloadVersion = 'v20.3.1';
+                break;
             default:
-                throw new Error('Invalid node version, must be 6, 10, or 16 (received ' + version + ')');
+                throw new Error('Invalid node version, must be 6, 10, 16, or 20 (received ' + version + ')');
         }
 
         // Install node in home directory if it isn't already there.
@@ -185,7 +188,10 @@ export class MockTestRunner {
         );
         const keys = Object.keys(execution);
         for (let i = 0; i < keys.length; i++) {
-            if (keys[i].toLowerCase() == 'node16') {
+            if (keys[i].toLowerCase() == 'node20') {
+                // Prefer node 20 and return immediately.
+                return 20;
+            } else if (keys[i].toLowerCase() == 'node16') {
                 // Prefer node 16 and return immediately.
                 return 16;
             } else if (keys[i].toLowerCase() == 'node10') {