Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Amateur Radio X.25 PLP Rose for CVE-2022-2961 #10826

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

rlmenge
Copy link
Contributor

@rlmenge rlmenge commented Oct 23, 2024

The rose_bind() function introduced a race condition which has a longstanding CVE. Therefore remove ROSE support.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This is a backport of changes at #10825
Kconfig
The rose_bind() function which is used in the AX.25 PLP Rose protocol introduced a race condition which has a longstanding CVE. Therefore remove rose support.

Change Log
Does this affect the toolchain?

YES

Associated issues

https://dev.azure.com/microsoft/OS/_workitems/edit/47170615

Test Methodology
image

The rose_bind() function introduced a race condition which has a
longstanding CVE. Therefore remove ROSE support.
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Oct 23, 2024
@rlmenge rlmenge marked this pull request as ready for review October 24, 2024 18:11
@rlmenge rlmenge requested a review from a team as a code owner October 24, 2024 18:11
@rlmenge rlmenge merged commit c5b6704 into main Oct 24, 2024
11 checks passed
@rlmenge rlmenge deleted the rlmenge/2.0/kernel/rose branch October 24, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants