Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby and rubygem-rexml: patch CVE-2024-49761 #10929

Merged

Conversation

Redent0r
Copy link
Contributor

@Redent0r Redent0r commented Nov 4, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

buddy build:

Patch adapted from ruby/rexml@ce59f2e
which fixes CVE-2024-49761 per https://nvd.nist.gov/vuln/detail/CVE-2024-49761

Needed for rubygem-rexml versions < 3.3.9

Signed-off-by: Saul Paredes <[email protected]>
@Redent0r Redent0r changed the title ruby: patch CVE-2024-49761 ruby and rubygem-rexml: patch CVE-2024-49761 Nov 4, 2024
@Redent0r Redent0r marked this pull request as ready for review November 4, 2024 23:24
@Redent0r Redent0r requested a review from a team as a code owner November 4, 2024 23:24
@Redent0r
Copy link
Contributor Author

Redent0r commented Nov 4, 2024

Looks like test failures from fast-track PR are not regressing based on https://dev.azure.com/mariner-org/mariner/_build?definitionId=1489&_a=summary
image

SPECS/ruby/ruby.spec Outdated Show resolved Hide resolved
Patch adapted from ruby/rexml@ce59f2e
which fixes CVE-2024-49761 per https://nvd.nist.gov/vuln/detail/CVE-2024-49761

Needed for ruby versions < 3.2.0

Signed-off-by: Saul Paredes <[email protected]>
@jslobodzian jslobodzian merged commit 1de07b4 into microsoft:fasttrack/2.0 Nov 7, 2024
14 of 18 checks passed
CBL-Mariner-Bot pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Saul Paredes <[email protected]>
Co-authored-by: jslobodzian <[email protected]>
(cherry picked from commit 1de07b4)
@CBL-Mariner-Bot
Copy link
Collaborator

@Redent0r Redent0r deleted the saulparedes/CVE-2024-49761 branch November 7, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants