Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby and rubygem-rexml: patch CVE-2024-49761 #10935

Open
wants to merge 2 commits into
base: fasttrack/3.0
Choose a base branch
from
Open

ruby and rubygem-rexml: patch CVE-2024-49761 #10935

wants to merge 2 commits into from
+97 −2

Conversation

Redent0r
Copy link
Contributor

@Redent0r Redent0r commented Nov 5, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

buddy build:

@Redent0r
rubygem-rexml: patch CVE-2024-49761
7c02211 
Patch adapted from ruby/rexml@ce59f2e
which fixes CVE-2024-49761 per https://nvd.nist.gov/vuln/detail/CVE-2024-49761

Needed for rubygem-rexml versions < 3.3.9

Signed-off-by: Saul Paredes <[email protected]>
@Redent0r Redent0r changed the title Saulparedes/3.0/CVE 2024 49761 ruby and rubygem-rexml: patch CVE-2024-49761 Nov 5, 2024
@Redent0r Redent0r force-pushed the saulparedes/3.0/CVE-2024-49761 branch from d52bf59 to d067f79 Compare November 5, 2024 20:08
@Redent0r
Copy link
Contributor Author

Redent0r commented Nov 5, 2024

Able to install both on 3.0 container
image

image

@Redent0r
Copy link
Contributor Author

Redent0r commented Nov 6, 2024

Double checked against https://dev.azure.com/mariner-org/mariner/_build/results?buildId=669633&view=ms.vss-test-web.build-test-results-tab and no new test failure regressions

@Redent0r Redent0r marked this pull request as ready for review November 6, 2024 00:18
@Redent0r Redent0r requested a review from a team as a code owner November 6, 2024 00:18
@Redent0r
ruby: patch CVE-2024-49761
11af426 
Patch adapted from ruby/rexml@ce59f2e
which fixes CVE-2024-49761 per https://nvd.nist.gov/vuln/detail/CVE-2024-49761

Needed for rubygem-rexml versions < 3.3.9

Signed-off-by: Saul Paredes <[email protected]>
@Redent0r Redent0r force-pushed the saulparedes/3.0/CVE-2024-49761 branch from d067f79 to 11af426 Compare November 7, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicogbg nicogbg nicogbg approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Redent0r @nicogbg