Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Rook package in 3.0-dev #8625

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

sharath-srikanth-chellappa
Copy link
Contributor

@sharath-srikanth-chellappa sharath-srikanth-chellappa commented Mar 30, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

The PR removes the rook package from 3.0-dev since no one is using rook and it does not make sense to have a package that no one uses.

Change Log
  • Deleting SPECS/rook
  • Editing cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

No build since it is a deletion of a package

@sharath-srikanth-chellappa sharath-srikanth-chellappa added the 3.0-dev PRs Destined for AzureLinux 3.0 label Mar 30, 2024
@sharath-srikanth-chellappa sharath-srikanth-chellappa merged commit bcfedf7 into 3.0-dev Apr 4, 2024
14 checks passed
@sharath-srikanth-chellappa sharath-srikanth-chellappa deleted the sharathsr/3.0/rook-update branch April 4, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants