Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop bazel-workspaces #8675

Merged

Conversation

dmcilvaney
Copy link
Contributor

@dmcilvaney dmcilvaney commented Apr 3, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

bazel-workspaces was brought in for envoy, but we no longer have envoy.

There appear to be no additional dependencies on the package (via depsearch and dnf repoquery)

Change Log
  • Remove bazel-workspaces
Does this affect the toolchain?

NO

Test Methodology
  • Local analysis

@dmcilvaney dmcilvaney changed the title Drop bazel-workspaces, fdupes, patchelf, golang-packaging, demote gcovr. Drop bazel-workspaces Apr 3, 2024
@dmcilvaney dmcilvaney marked this pull request as ready for review April 3, 2024 18:09
@dmcilvaney dmcilvaney requested a review from a team as a code owner April 3, 2024 18:09
@dmcilvaney dmcilvaney added the 3.0-dev PRs Destined for AzureLinux 3.0 label Apr 4, 2024
@dmcilvaney dmcilvaney merged commit 215f6b4 into microsoft:3.0-dev Apr 9, 2024
13 checks passed
@dmcilvaney dmcilvaney deleted the damcilva/3.0/upgrades/bazel-workspaces branch April 9, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants