Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Customizer: Operation ordering + scripts refactor. #8697

Merged

Conversation

cwize1
Copy link
Contributor

@cwize1 cwize1 commented Apr 3, 2024

  1. Only regenerate the initramfs file once during customization, to save time.

  2. Regenerate the initramfs file by directly calling mkinitrd instead of reinstalling the initramfs package, to save time and reduce complexity.

  3. Remove the existing os.postInstallScripts and os.finalizeImageScripts properties, and replace them with new scripts.postCustomization and scripts.finalizeCustomization properties.

  4. Move of the setting SELinux mode to be before the postCustomization scripts.

  5. Move the adding of the verity and overlayfs dracut modules to be before the postCustomization scripts.


Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Does this affect the toolchain?

NO

Test Methodology
  • Manually ran image customizer tool.

@cwize1 cwize1 requested review from a team as code owners April 3, 2024 23:47
1. Only regenerate the initramfs file once during customization, to
save time.

2. Regenerate the initramfs file by directly calling `mkinitrd` instead
of reinstalling the `initramfs` package, to save time and reduce
complexity.

3. Remove the existing `os.postInstallScripts` and
`os.finalizeImageScripts` properties, and replace them with new
`scripts.postCustomization` and `scripts.finalizeCustomization`
properties.

4. Move of the setting SELinux mode to be before the
`postCustomization` scripts.

5. Move the adding of the verity and overlayfs dracut modules to be
before the `postCustomization` scripts.
@cwize1 cwize1 force-pushed the user/chrisgun/micScriptReorganization branch from dfb00f3 to c92a033 Compare April 11, 2024 18:28
@cwize1 cwize1 merged commit 9fe2dd5 into microsoft:3.0-dev Apr 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants