Best practices for testing #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plasne
requested review from
TessFerrandez,
shiranr and
nyouens
as code owners
|
@TessFerrandez, the MegaLinter problems all seem to be related to articles other than the stuff I am submitting for. Any thoughts? |
|
Hi @plasne |
|
I'm fixing the broken links in #998 so please approve that and then merge it into yours |
TessFerrandez
approved these changes
Oct 3, 2023
|
Thank you for the contribution! |
…icrosoft/code-with-engineering-playbook into pelasne/build-for-testing
…/code-with-engineering-playbook into pelasne/build-for-testing
|
Thanks, @TessFerrandez , merging that branch seemed to work. |
stuartleeks
reviewed
Oct 18, 2023
stuartleeks
reviewed
Oct 18, 2023
|
@stuartleeks can you review again, I think all the comments are addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
This comes from the hydro crew's latest engagement and we believe might be helpful to other crews.