fix(foundation): tabs minimum value to grid column on transition #6580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6543) <!--- Thanks for filing a pull request 😄 ! Before you submit, please read the following: Search open/closed issues before submitting. Someone may have pushed the same thing before! Provide a summary of your changes in the title field above. --> # Pull Request ## 📖 Description <!--- Provide some background and a description of your work. What problem does this change solve? Is this a breaking change, chore, fix, feature, etc? --> ### 🎫 Issues <!--- * List and link relevant issues here. --> ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. Do you recommend a smoke test for this PR? What steps should be followed? Are there particular areas of the code the reviewer should focus on? --> ## 📑 Test Plan <!--- Please provide a summary of the tests affected by this work and any unique strategies employed in testing the features/fixes. --> ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [ ] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [ ] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project. ### Component-specific <!--- Review the list and put an x in the boxes that apply. --> <!--- Remove this section if not applicable. --> - [ ] I have added a new component - [ ] I have modified an existing component - [ ] I have updated the [definition file](https://github.com/microsoft/fast/blob/master/packages/web-components/fast-components/CONTRIBUTING.md#definition) - [ ] I have updated the [configuration file](https://github.com/microsoft/fast/blob/master/packages/web-components/fast-components/CONTRIBUTING.md#configuration) ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. -->
yinonov
changed the title
yinonov
changed the title
9 tasks
yinonov
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
|
This is just an fyi/workaround for this issue, for folks that are still using the archived If you set an initial <fast-tabs activeid="tab-1">
<fast-tab slot="tab" id="tab-1">Tab one</fast-tab>
<fast-tab slot="tab" id="tab-2">Tab two</fast-tab>
<fast-tab slot="tab" id="tab-3">Tab three</fast-tab>
<fast-tab-panel slot="tabpanel">Tab panel 1</fast-tab-panel>
<fast-tab-panel slot="tabpanel">Tab panel 2</fast-tab-panel>
<fast-tab-panel slot="tabpanel">Tab panel 3</fast-tab-panel>
</fast-tabs> |
personally I think css should enforce defaults on its own to protect run-time from such cases. anyway, this suggested workaround would need to be documented to authors as a caveat and, fairly, this could be forgotten easily. it's a matter of ergonomics |
|
Fixes #6455 (?) |
yinonov
pushed a commit
to Vonage/vivid-3
that referenced
this pull request
Jan 4, 2023
|
Looks like we need to add a change file, can you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tabs active-indicator is janky on first change due to its
grid-columncss property being set to0.this is now fixed by conditionally assigning a value of, at least,
1instead if equals0.Pull Request
📖 Description
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps