Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelayMockPayloadGenerator supports nested lists #473

Merged
merged 5 commits into from
Nov 18, 2024
Merged

RelayMockPayloadGenerator supports nested lists #473

merged 5 commits into from
Nov 18, 2024

Conversation

fidelman
Copy link
Contributor

@fidelman fidelman commented Nov 6, 2024

Closes #438

@fidelman
Copy link
Contributor Author

fidelman commented Nov 6, 2024

@fidelman please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

user1736
user1736 reviewed Nov 6, 2024
View reviewed changes
packages/graphql-js-operation-payload-generator/src/index.ts Outdated
@@ -154,8 +159,11 @@ export function generate<TypeMap extends DefaultMockResolvers>(
if (isList) {
const value = source[selectionName];
const result = Array.isArray(value)
? value.map(generateValue)
: [generateValue(value as object)];
? applyLogicToNestedArray(value, generateValue)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added tests

@fidelman fidelman merged commit 19d6454 into microsoft:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@user1736 user1736 user1736 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RelayPayloadMockGenerator doesn't support nested lists
2 participants
@fidelman @user1736