-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calling procedures with output parameters by their four-part syntax #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
=============================================
- Coverage 73.56% 49.99% -23.57%
+ Complexity 6079 3789 -2290
=============================================
Files 143 143
Lines 33179 33189 +10
Branches 5631 5631
=============================================
- Hits 24407 16594 -7813
- Misses 6255 14214 +7959
+ Partials 2517 2381 -136 ☔ View full report in Codecov by Sentry. |
Jeffery-Wasty
approved these changes
Mar 18, 2024
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Show resolved
Hide resolved
barryw-mssql
approved these changes
Mar 19, 2024
tkyc
added a commit
that referenced
this pull request
May 22, 2024
…ax (#2349) * Corrected four part syntax regression * JDK 8 correction
Jeffery-Wasty
pushed a commit
that referenced
this pull request
May 22, 2024
…2427) * Fix calling procedures with output parameters by their four-part syntax (#2349) * Corrected four part syntax regression * JDK 8 correction * Execute stored procedures directly for RPC calls (#2410) * RPC fix * Assertion index correction * Removed magic number * Removed login drop command * Code review changes * Formatting * Test config changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2344