-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TDSType.GUID (fix) (#1582) #2370
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
============================================
- Coverage 50.10% 50.07% -0.03%
- Complexity 3813 3817 +4
============================================
Files 145 145
Lines 33286 33319 +33
Branches 5639 5644 +5
============================================
+ Hits 16677 16684 +7
- Misses 14221 14254 +33
+ Partials 2388 2381 -7 ☔ View full report in Codecov by Sentry. |
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/GuidTest.java
Outdated
Show resolved
Hide resolved
@lilgreenbird Thanks for the correction. I wasn't aware of this Azure SQL Data Warehouse limitation. |
This is a fix for the merged and reverted PR #2324.
The original PR intends to provide support for sending UUID parameters as
TDSType.GUID (0x24)
on the wire and (hopefully) implements feature request #1582.It currently requires the Java parameter be given to the driver as
String
withJDBCType.GUID
, i.e. :