Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared statement objects should be reusable #2482

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Prepared statement objects should be reusable #2482

merged 1 commit into from
Aug 21, 2024

Conversation

tkyc
Copy link
Contributor

@tkyc tkyc commented Jul 24, 2024

Discovered that when attempting to reuse the same pstmt object, the driver would error out with R_multipleQueriesNotAllowed and consume that error.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.78%. Comparing base (0e97689) to head (ed981ca).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2482      +/-   ##
============================================
- Coverage     50.78%   50.78%   -0.01%     
+ Complexity     3888     3887       -1     
============================================
  Files           145      145              
  Lines         33481    33479       -2     
  Branches       5690     5689       -1     
============================================
- Hits          17004    17002       -2     
  Misses        14030    14030              
  Partials       2447     2447              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jeffery-Wasty
Jeffery-Wasty previously approved these changes Jul 25, 2024
@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.8.0, 12.9.0 Jul 25, 2024
@Jeffery-Wasty Jeffery-Wasty self-requested a review July 25, 2024 19:08
@Jeffery-Wasty Jeffery-Wasty dismissed their stale review July 25, 2024 19:08

Re-review for 12.9 preview

@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.9.0, 12.8.1 Aug 15, 2024
Copy link
Contributor

@lilgreenbird lilgreenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test?

@tkyc
Copy link
Contributor Author

tkyc commented Aug 20, 2024

This error isn't explicitly thrown, so I can't really test by not looking for it. In the old code, this error was consumed and the driver would keep running.

@tkyc tkyc merged commit c05521e into main Aug 21, 2024
19 checks passed
@tkyc tkyc deleted the pstmt-reuse-fix branch August 21, 2024 23:15
tkyc added a commit that referenced this pull request Aug 21, 2024
@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.8.1, 12.9.0 Aug 21, 2024
tkyc added a commit that referenced this pull request Aug 22, 2024
tkyc added a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

3 participants