-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepared statement objects should be reusable #2482
Conversation
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
============================================
- Coverage 50.78% 50.78% -0.01%
+ Complexity 3888 3887 -1
============================================
Files 145 145
Lines 33481 33479 -2
Branches 5690 5689 -1
============================================
- Hits 17004 17002 -2
Misses 14030 14030
Partials 2447 2447 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test?
This error isn't explicitly thrown, so I can't really test by not looking for it. In the old code, this error was consumed and the driver would keep running. |
Discovered that when attempting to reuse the same pstmt object, the driver would error out with
R_multipleQueriesNotAllowed
and consume that error.