Phi-3 Vision Android App #456
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natke
requested review from
skottmckay,
edgchen1 and
EmmaNingMS
and removed request for
skottmckay,
edgchen1 and
EmmaNingMS
edgchen1
reviewed
Aug 15, 2024
|
|
||
|
|
||
| inputTensors = multiModalProcessor.processImages(promptQuestion_formatted, images); | ||
| generatorParams.setInput(inputTensors); |
There was a problem hiding this comment.
had to update this to get it to build:
Suggested change
| generatorParams.setInput(inputTensors); | |
| generatorParams.setInputs(inputTensors); |
edgchen1
reviewed
Aug 15, 2024
| FileOutputStream out = new FileOutputStream(filename); | ||
| bmp.compress(Bitmap.CompressFormat.PNG, 100, out); // bmp is your Bitmap instance | ||
| // PNG is a lossless format, the compression factor (100) is ignored | ||
| images = new Images(filename); |
There was a problem hiding this comment.
FYI, was running into an error here:
java.lang.UnsatisfiedLinkError: No implementation found for long ai.onnxruntime.genai.Images.loadImages(java.lang.String) (tried Java_ai_onnxruntime_genai_Images_loadImages and Java_ai_onnxruntime_genai_Images_loadImages__Ljava_lang_String_2) - is the library loaded, e.g. System.loadLibrary?
this ort-genai PR should fix it:
microsoft/onnxruntime-genai#797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Phi-3 Vision support to "Local Chatbot on Android with Phi-3, ONNX Runtime Mobile and ONNX Runtime Generate() API" project using the generate() Java API.
Main changes: