Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Regenerate Libraries #464

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Regenerate Libraries #464

wants to merge 12 commits into from

Conversation

ScottCarda-MS
Copy link
Contributor

No description provided.

@ScottCarda-MS ScottCarda-MS changed the title Sccarda/regenerate libraries Regenerate Libraries Dec 17, 2020
| true, outputType -> outputType = AssemblyConstants.QsharpExe
| _ -> false

if isExe then
Copy link
Contributor

@bettinaheim bettinaheim Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for determining whether to emit C# for a particular source (whether source code or an assembly reference) is handled by GenerateCodeForSource. Please adapt it there rather than adding an additional branching here.

@bettinaheim
Copy link
Contributor

@ScottCarda-MS I believe this is a change that will be needed to enable turning on monomorphization by default, correct? Shall we keep this PR, or shall we close it and you'll set up a new one on top of all the latest changes?

@ScottCarda-MS
Copy link
Contributor Author

@ScottCarda-MS I believe this is a change that will be needed to enable turning on monomorphization by default, correct? Shall we keep this PR, or shall we close it and you'll set up a new one on top of all the latest changes?

@bettinaheim I'd like to keep it around if it is not too much trouble. It serves as a good reminder to me for what needs to be picked back up when I finally get back to this point in the work stack. Otherwise I will lose more context on the task.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants