Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send mouseUp events for NSTabView #2112

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Send mouseUp events for NSTabView #2112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-native/React/Base/RCTTouchHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ - (void)_recordNewTouches:(NSSet *)touches
// Pair the mouse down events with mouse up events so our _nativeTouches cache doesn't get stale
if ([targetView isKindOfClass:[NSControl class]]) {
_shouldSendMouseUpOnSystemBehalf = [(NSControl*)targetView isEnabled];
} else if ([targetView isKindOfClass:[NSTabView class]]) {
// NSTabView sends click events for tab buttons but doesn't inherit from NSControl
_shouldSendMouseUpOnSystemBehalf = YES;
} else if ([targetView isKindOfClass:[NSText class]]) {
_shouldSendMouseUpOnSystemBehalf = [(NSText*)targetView isSelectable];
}
Expand Down