-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bring publish pipeline updates from 0.76-stable
to main
#2314
base: main
Are you sure you want to change the base?
Conversation
@tido64 apart from the failure with |
@@ -112,7 +112,7 @@ | |||
}, | |||
"dependencies": { | |||
"@jest/create-cache-key-function": "^29.6.3", | |||
"@react-native-mac/virtualized-lists": "workspace:*", | |||
"@react-native-mac/virtualized-lists": "0.76.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be reverted?
@@ -112,7 +112,7 @@ | |||
}, | |||
"dependencies": { | |||
"@jest/create-cache-key-function": "^29.6.3", | |||
"@react-native-mac/virtualized-lists": "workspace:*", | |||
"@react-native-mac/virtualized-lists": "0.76.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the change from workspace:*
to 0.76.4
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the notes in this PR: #2318
As Tommy pointed out, I should revert for the main branch.
Summary:
We've made a couple of updates to the publish pipeline in 0.76-stable. Let's bring them to
main
Test Plan:
CI should pass