Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bring publish pipeline updates from 0.76-stable to main #2314

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Dec 6, 2024

Summary:

We've made a couple of updates to the publish pipeline in 0.76-stable. Let's bring them to main

Test Plan:

CI should pass

@Saadnajmi Saadnajmi requested a review from a team as a code owner December 6, 2024 00:19
@Saadnajmi
Copy link
Collaborator Author

@tido64 apart from the failure with nx-release-publish, I think I'll call this ready to review. We won't be publishing out of main yet anyway so it should be fine.

@@ -112,7 +112,7 @@
},
"dependencies": {
"@jest/create-cache-key-function": "^29.6.3",
"@react-native-mac/virtualized-lists": "workspace:*",
"@react-native-mac/virtualized-lists": "0.76.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be reverted?

@@ -112,7 +112,7 @@
},
"dependencies": {
"@jest/create-cache-key-function": "^29.6.3",
"@react-native-mac/virtualized-lists": "workspace:*",
"@react-native-mac/virtualized-lists": "0.76.4",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the change from workspace:* to 0.76.4?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the notes in this PR: #2318
As Tommy pointed out, I should revert for the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants