fix: windows linter issue (#41)

Some of the files the windows linter is complaining about are from linux-only plugins. Adding `_linux` suffix to each of them should resolve it for now.
microsoft · Mar 14, 2024 · 59a758d · 59a758d
1 parent 1231645
commit 59a758d
Show file tree

Hide file tree

Showing 24 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -29,7 +29,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
         run: |
-          make retina-test-image PLATFORM=linux/amd64
+          make retina-test-image IMAGE_NAMESPACE=${{ github.repository }} PLATFORM=linux/amd64
       - name: Upload Artifacts
         uses: actions/upload-artifact@v4
         with:

diff --git a/controller/Dockerfile.controller b/controller/Dockerfile.controller
@@ -37,7 +37,8 @@ ARG APP_INSIGHTS_ID
 
 RUN go build -v -o /go/bin/retina/controller -ldflags "-X main.version="$VERSION" -X "main.applicationInsightsID"="$APP_INSIGHTS_ID"" controller/main.go 
 RUN go build -v -o /go/bin/retina/captureworkload -ldflags "-X main.version="$VERSION" -X "main.applicationInsightsID"="$APP_INSIGHTS_ID"" captureworkload/main.go
-RUN go build -v -o /go/bin/retina/initretina -ldflags "-X main.version="$VERSION" -X "main.applicationInsightsID"="$APP_INSIGHTS_ID"" ././init/retina/main.go
+# We only build initretina for linux.
+RUN go build -v -o /go/bin/retina/initretina -ldflags "-X main.version="$VERSION" -X "main.applicationInsightsID"="$APP_INSIGHTS_ID"" ././init/retina/main_linux.go
 
 
 # ----------------------------------------------------------------------------------- #

diff --git a/init/retina/main.go → init/retina/main_linux.go b/init/retina/main.go → init/retina/main_linux.go
diff --git a/pkg/bpf/setup.go → pkg/bpf/setup_linux.go b/pkg/bpf/setup.go → pkg/bpf/setup_linux.go
diff --git a/pkg/plugin/dns/dns_test.go → pkg/plugin/dns/dns_linux_test.go b/pkg/plugin/dns/dns_test.go → pkg/plugin/dns/dns_linux_test.go
diff --git a/pkg/plugin/dns/types.go → pkg/plugin/dns/types_linux.go b/pkg/plugin/dns/types.go → pkg/plugin/dns/types_linux.go
diff --git a/pkg/plugin/dropreason/dropreason_test.go → ...lugin/dropreason/dropreason_linux_test.go b/pkg/plugin/dropreason/dropreason_test.go → ...lugin/dropreason/dropreason_linux_test.go
diff --git a/pkg/plugin/filter/filter_map_test.go → pkg/plugin/filter/filter_map_linux_test.go b/pkg/plugin/filter/filter_map_test.go → pkg/plugin/filter/filter_map_linux_test.go
diff --git a/pkg/plugin/linuxutil/ethtool_stats.go → pkg/plugin/linuxutil/ethtool_stats_linux.go b/pkg/plugin/linuxutil/ethtool_stats.go → pkg/plugin/linuxutil/ethtool_stats_linux.go
diff --git a/pkg/plugin/linuxutil/ethtool_stats_test.go → ...gin/linuxutil/ethtool_stats_linux_test.go b/pkg/plugin/linuxutil/ethtool_stats_test.go → ...gin/linuxutil/ethtool_stats_linux_test.go
diff --git a/pkg/plugin/linuxutil/linuxutil.go → pkg/plugin/linuxutil/linuxutil_linux.go b/pkg/plugin/linuxutil/linuxutil.go → pkg/plugin/linuxutil/linuxutil_linux.go
diff --git a/pkg/plugin/linuxutil/linuxutil_test.go → pkg/plugin/linuxutil/linuxutil_linux_test.go b/pkg/plugin/linuxutil/linuxutil_test.go → pkg/plugin/linuxutil/linuxutil_linux_test.go
diff --git a/pkg/plugin/linuxutil/netstat_stats.go → pkg/plugin/linuxutil/netstat_stats_linux.go b/pkg/plugin/linuxutil/netstat_stats.go → pkg/plugin/linuxutil/netstat_stats_linux.go
diff --git a/pkg/plugin/linuxutil/netstat_stats_test.go → ...gin/linuxutil/netstat_stats_linux_test.go b/pkg/plugin/linuxutil/netstat_stats_test.go → ...gin/linuxutil/netstat_stats_linux_test.go
diff --git a/pkg/plugin/linuxutil/types.go → pkg/plugin/linuxutil/types_linux.go b/pkg/plugin/linuxutil/types.go → pkg/plugin/linuxutil/types_linux.go
diff --git a/pkg/plugin/packetparser/packetparser_test.go → ...n/packetparser/packetparser_linux_test.go b/pkg/plugin/packetparser/packetparser_test.go → ...n/packetparser/packetparser_linux_test.go
diff --git a/pkg/plugin/tcpretrans/types.go → pkg/plugin/tcpretrans/types_linux.go b/pkg/plugin/tcpretrans/types.go → pkg/plugin/tcpretrans/types_linux.go
diff --git a/pkg/telemetry/heartbeat_windows_test.go b/pkg/telemetry/heartbeat_windows_test.go
@@ -11,7 +11,7 @@ import (
 )
 
 func TestWindowsGetKernelVersion(t *testing.T) {
-	InitAppInsights("")
+	InitAppInsights("", "")
 	ctx := context.TODO()
 
 	str, err := KernelVersion(ctx)

diff --git a/pkg/watchers/endpoint/endpoint_test.go → pkg/watchers/endpoint/endpoint_linux_test.go b/pkg/watchers/endpoint/endpoint_test.go → pkg/watchers/endpoint/endpoint_linux_test.go
diff --git a/test/plugin/dns/main.go → test/plugin/dns/main_linux.go b/test/plugin/dns/main.go → test/plugin/dns/main_linux.go
diff --git a/test/plugin/dropreason/main.go → test/plugin/dropreason/main_linux.go b/test/plugin/dropreason/main.go → test/plugin/dropreason/main_linux.go
diff --git a/test/plugin/linuxutil/main.go → test/plugin/linuxutil/main_linux.go b/test/plugin/linuxutil/main.go → test/plugin/linuxutil/main_linux.go
diff --git a/test/plugin/packetforward/main.go → test/plugin/packetforward/main_linux.go b/test/plugin/packetforward/main.go → test/plugin/packetforward/main_linux.go
diff --git a/test/plugin/packetparser/main.go → test/plugin/packetparser/main_linux.go b/test/plugin/packetparser/main.go → test/plugin/packetparser/main_linux.go