check condition in one line

microsoft · Oct 25, 2024 · add4c02 · add4c02
1 parent abcf186
commit add4c02
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/test/e2e/framework/prometheus/prometheus.go b/test/e2e/framework/prometheus/prometheus.go
@@ -85,10 +85,8 @@ func verifyValidMetricPresent(metricName string, data map[string]*promclient.Met
 				}
 
 				// if valid metric is empty, then we just need to make sure the metric and value is present
-				if len(validMetric) == 0 {
-					if len(metricLabels) > 0 {
-						return nil
-					}
+				if len(validMetric) == 0 && len(metricLabels) > 0 {
+					return nil
 				}
 
 				if reflect.DeepEqual(metricLabels, validMetric) {