Add no_std feature and make it default for win_etw_provider #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not deeply tested but appears to compile and work when added to another project with a global allocator.
|
Ah, looks like the test runners are pinned to 1.68.0, which is before core stabilized SocketAddrV4, etc. (I believe this was fairly recent). Is there a reason the test runners need to be pinned to 1.68.0 specifically? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate is very close to being no_std as it is. At this point the only portion that cannot be done in no_std is, appropriately enough, the std_support module.
This change adds a no_std feature, makes it default, and makes minor tweaks to maximize no_std compatibility (using widestring's "alloc" feature, updating the IP structs to their core versions, adding a few references to the alloc crate.)