Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum support pycocotools version #1484

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

adamjstewart
Copy link
Collaborator

pycocotools is failing to build in #1483. I want to investigate if this is broken in main and what the cause of the issue is.

@adamjstewart
Copy link
Collaborator Author

This can't be a coincidence: https://pypi.org/project/Cython/#history

@github-actions github-actions bot added the dependencies Packaging and dependencies label Jul 18, 2023
@adamjstewart adamjstewart marked this pull request as ready for review July 18, 2023 18:02
@github-actions github-actions bot added the testing Continuous integration testing label Jul 18, 2023
@github-actions github-actions bot removed the testing Continuous integration testing label Jul 18, 2023
@adamjstewart adamjstewart added this to the 0.4.2 milestone Jul 18, 2023
@adamjstewart
Copy link
Collaborator Author

Pip does not provide a way to control the versions of build dependencies, so our only option is to change the minimum version of pycocotools we support.

@adamjstewart adamjstewart changed the title Investigate pycocotools build issues Bump minimum support pycocotools version Jul 18, 2023
@adamjstewart adamjstewart merged commit 17e1de3 into microsoft:main Jul 19, 2023
20 checks passed
@adamjstewart adamjstewart deleted the deps/pycocotools branch July 19, 2023 14:20
@adamjstewart adamjstewart modified the milestones: 0.4.2, 0.5.0 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Packaging and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants