Merge pull request #12731 from microsoft/main

Merge to vs

.github/actions/AddComment/AddComment.ts

@@ -10,7 +10,7 @@ import { daysAgoToHumanReadbleDate, daysAgoToTimestamp, safeLog } from '../commo
 export class AddComment extends ActionBase {
 	constructor(
 		private github: GitHub,
-		private createdAfter: string,
+		private createdAfter: string | undefined,
 		private afterDays: number,
 		labels: string,
 		private addComment: string,
@@ -45,6 +45,23 @@ export class AddComment extends ActionBase {
 				if (hydrated.open && this.validateIssue(hydrated)
 					// TODO: Verify updated timestamp
 				) {
+					// Don't add a comment if already commented on by an action.
+					let foundActionComment = false;
+					for await (const commentBatch of issue.getComments()) {
+						for (const comment of commentBatch) {
+							if (comment.author.isGitHubApp) {
+								foundActionComment = true;
+								break;
+							}
+						}
+						if (foundActionComment)
+							break;
+					}
+					if (foundActionComment) {
+						safeLog(`Issue ${hydrated.number} already commented on by an action. Ignoring.`);
+						continue;
+					}
+
 					if (this.addComment) {
 						safeLog(`Posting comment on issue ${hydrated.number}`);
 						await issue.postComment(this.addComment);

.github/workflows/bug-debugger.yml

@@ -1,7 +1,7 @@
 name: Bug - debugger
 on:
   schedule:
-    - cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
+    - cron: 50 12 * * * # Run at 12:50 PM UTC (4:50 AM PST, 5:50 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/by-design-closer-debugger .yml

@@ -1,7 +1,7 @@
 name: By Design closer - debugger
 on:
   schedule:
-    - cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
+    - cron: 0 13 * * * # Run at 1:00 PM UTC (5:00 AM PST, 6:00 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/enhancement-closer-no-milestone.yml

@@ -1,7 +1,7 @@
 name: Enhancement Closer (no milestone)
 on:
   schedule:
-    - cron: 50 11 * * * # Run at 11:50 AM UTC (3:50 AM PST, 4:50 AM PDT)
+    - cron: 40 12 * * * # Run at 12:40 PM UTC (4:40 AM PST, 5:40 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/enhancement-closer-triage.yml

@@ -1,7 +1,7 @@
 name: Enhancement Closer (Triage)
 on:
   schedule:
-    - cron: 40 11 * * * # Run at 11:40 AM UTC (3:40 AM PST, 4:40 AM PDT)
+    - cron: 30 12 * * * # Run at 12:30 PM UTC (4:30 AM PST, 5:30 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/enhancement-reopener.yml

@@ -1,7 +1,7 @@
 name: Enhancement Reopener
 on:
   schedule:
-    - cron: 20 12 * * * # Run at 12:20 PM UTC (4:20 AM PST, 5:20 AM PDT)
+    - cron: 0 11 * * * # Run at 11:00 AM UTC (3:00 AM PST, 4:00 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/external-closer-debugger.yml

@@ -1,7 +1,7 @@
 name: External closer - debugger
 on:
   schedule:
-    - cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
+    - cron: 10 13 * * * # Run at 1:10 PM UTC (5:10 AM PST, 6:10 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/feature-request-debugger.yml

@@ -1,7 +1,7 @@
 name: Feature Request - debugger
 on:
   schedule:
-    - cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
+    - cron: 20 13 * * * # Run at 1:20 PM UTC (5:20 AM PST, 6:20 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/investigate-closer-debugger.yml

@@ -1,7 +1,7 @@
 name: Investigate closer - debugger
 on:
   schedule:
-    - cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
+    - cron: 30 13 * * * # Run at 1:30 PM UTC (5:30 AM PST, 6:30 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/investigate-costing-closer-debugger.yml

@@ -1,7 +1,7 @@
 name: Investigate Costing closer - debugger
 on:
   schedule:
-    - cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
+    - cron: 40 13 * * * # Run at 1:40 PM UTC (5:40 AM PST, 6:40 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/more-info-needed-closer-debugger.yml

@@ -1,7 +1,7 @@
 name: More Info Needed Closer - debugger
 on:
   schedule:
-    - cron: 10 11 * * * # Run at 11:10 AM UTC (3:10 AM PST, 4:10 AM PDT)
+    - cron: 50 13 * * * # Run at 1:50 PM UTC (5:50 AM PST, 6:50 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

.github/workflows/question-closer-debugger.yml

@@ -1,7 +1,7 @@
 name: Question Closer - debugger
 on:
   schedule:
-    - cron: 20 11 * * * # Run at 11:20 AM UTC (3:20 AM PST, 4:20 AM PDT)
+    - cron: 0 14 * * * # Run at 2:00 PM UTC (6:00 AM PST, 7:00 AM PDT)
   workflow_dispatch:
    inputs:
      readonly:

Extension/.scripts/common.ts

@@ -325,6 +325,7 @@ export async function checkDTS() {
     let failing = false;
     failing = !await assertAnyFile('vscode.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.d.ts is missing.`)) || failing;
     failing = !await assertAnyFile('vscode.proposed.terminalDataWriteEvent.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.proposed.terminalDataWriteEvent.d.ts is missing.`)) || failing;
+    failing = !await assertAnyFile('vscode.proposed.lmTools.d.ts') && (quiet || warn(`The VSCode import file '${$root}/dist/src/vscode.proposed.lmTools.d.ts is missing.`)) || failing;
 
     if (!failing) {
         verbose('VSCode d.ts files appear to be in place.');

Extension/.vscode/settings.json

@@ -37,7 +37,7 @@
     },
     "[typescript]": {
         "editor.tabSize": 4,
-        "editor.defaultFormatter": "dbaeumer.vscode-eslint",
+        "editor.defaultFormatter": "vscode.typescript-language-features",
         "editor.formatOnSave": true,
         "files.insertFinalNewline": true,
         "editor.codeActionsOnSave": {

Extension/CHANGELOG.md

@@ -1,16 +1,52 @@
 # C/C++ for Visual Studio Code Changelog
 
-## Version 1.22.0: August 21, 2024
+## Version 1.22.3: September 12, 2024
+### Enhancement
+* Add support for providing additional context information to Copilot Chat. [PR #12685](https://github.com/microsoft/vscode-cpptools/pull/12685)
+  * Currently, it requires `"C_Cpp.experimentalFeatures": "enabled"` and typing `#cpp` in the chat.
+
+### Bug Fixes
+* Fix the compiler selection control not keeping the list in sync with contents of the textbox. [#7427](https://github.com/microsoft/vscode-cpptools/issues/7427)
+* Fix a string localization issue. [#7824](https://github.com/microsoft/vscode-cpptools/issues/7824) 
+* Stop logging duplicate compiler path messages. [#12445](https://github.com/microsoft/vscode-cpptools/issues/12445)
+* Fix some crashes with recursive includes. [#12643](https://github.com/microsoft/vscode-cpptools/issues/12643)
+* Fix a rare crash on macOS related to `get_memory_usage`. [#12667](https://github.com/microsoft/vscode-cpptools/issues/12667)
+* Fix an issue with 'Extract to Function' formatting. [#12677](https://github.com/microsoft/vscode-cpptools/issues/12677)
+* Fix a potential deadlock in `process_paths`. [#12690](https://github.com/microsoft/vscode-cpptools/issues/12690)
+
+## Version 1.22.2: August 29, 2024
+### Enhancement
+* Remove the `C_Cpp.intelliSenseEngineFallback` setting. [#12596](https://github.com/microsoft/vscode-cpptools/issues/12596)
+
+### Bug Fix
+* Fix a deadlock when doing "Find All References" and a file is deleted. [#12656](https://github.com/microsoft/vscode-cpptools/issues/12656)
+
+## Version 1.22.1: August 29, 2024
+### Enhancement
+* Add "Additional Tracked Settings" to `C/C++: Log Diagnostics` output. [PR #12635](https://github.com/microsoft/vscode-cpptools/pull/12635)
+
+### Bug Fixes
+* Fix hover over static constexpr variables sometimes not working. [#12284](https://github.com/microsoft/vscode-cpptools/issues/12284)
+* Fix completion not giving results in several scenarios. [#12412](https://github.com/microsoft/vscode-cpptools/issues/12412)
+* Fix include completion showing results for deleted folders with recursive includes. [#12636](https://github.com/microsoft/vscode-cpptools/issues/12636)
+* Fix the `/FU` flag not working for C++/CLI . [#12641](https://github.com/microsoft/vscode-cpptools/issues/12641)
+* Fix some crashes with recursive includes. [#12643](https://github.com/microsoft/vscode-cpptools/issues/12643)
+* Fix IntelliSense not working on Windows when `C_Cpp.caseSensitiveFileSupport` is `enabled`. [#12648](https://github.com/microsoft/vscode-cpptools/issues/12648)
+* Changes that might fix a crash with `translate_encoding_to_utf8`. [#12652](https://github.com/microsoft/vscode-cpptools/issues/12652)
+* Fix a random crash during IntelliSense creation.
+
+## Version 1.22.0: August 26, 2024
 ### Performance Improvements
 * Switch to an alternative implementation of recursive includes (that sends all the paths instead of only the "used" paths). [#11780](https://github.com/microsoft/vscode-cpptools/issues/11780)
   - Performance improvement: Configuration is no longer blocked on tag parsing of all dependent headers.
-  - Configuration change: Recursive include paths now always take precedence over system include paths (similar to compiler behavior and non-recursive includes). [#11485](https://github.com/microsoft/vscode-cpptools/issues/11485)
+  - Configuration change: Recursive include paths now take precedence over system include paths (similar to compiler behavior and non-recursive includes). [#11485](https://github.com/microsoft/vscode-cpptools/issues/11485)
 * Initialization performance improvements. [#12030](https://github.com/microsoft/vscode-cpptools/issues/12030)
   - Some processing is parallelized and started earlier (populating the filename cache, discovering files). [#11954](https://github.com/microsoft/vscode-cpptools/issues/11954), [#12169](https://github.com/microsoft/vscode-cpptools/issues/12169)
   - Some compiler configuration queries are cached in the database, and processing of compile_commands.json was improved. [#10029](https://github.com/microsoft/vscode-cpptools/issues/10029), [#12078](https://github.com/microsoft/vscode-cpptools/issues/12078)
 * Improve the implementation of file buffers to reduce memory usage.
 
 ### Enhancements
+* Add modified `C_Cpp` settings to the `C/C++: Log Diagnostics` output. [#11700](https://github.com/microsoft/vscode-cpptools/issues/11700)
 * Change the default C/C++ `"editor.stickyScroll.defaultModel"` to `"foldingProviderModel"`. [#12483](https://github.com/microsoft/vscode-cpptools/issues/12483)
 * Add better validation for settings. [#12371](https://github.com/microsoft/vscode-cpptools/issues/12371)
 * Various IntelliSense parsing updates/fixes.
@@ -20,13 +56,16 @@
 * Fix an issue where a file is incorrectly processed as C instead of C++. [#12466](https://github.com/microsoft/vscode-cpptools/issues/12466)
 * Fix include path ordering being incorrect if there is a duplicate. [#12525](https://github.com/microsoft/vscode-cpptools/issues/12525)
 * Fix a WebAssembly "Out of Memory" error. [#12529](https://github.com/microsoft/vscode-cpptools/issues/12529)
+* Fix an error message not being shown if the connection failed with remote attach debugging. [#12547](https://github.com/microsoft/vscode-cpptools/issues/12547)
+  * Thank you for the contribution. [@MrStanislav0 (Stanislav)](https://github.com/MrStanislav0)
 * Fix `-I` not being used if `-iquote` is also used for the same path. [#12551](https://github.com/microsoft/vscode-cpptools/issues/12551)
 * Fix issues with relative paths on `nvcc` (CUDA) command lines not being handled correctly. [#12553](https://github.com/microsoft/vscode-cpptools/issues/12553)
 * Fix a random crash when a child process is created. [#12585](https://github.com/microsoft/vscode-cpptools/issues/12585)
 * Fix a crash on shutdown on macOS with a verbose logging level. [#12567](https://github.com/microsoft/vscode-cpptools/issues/12567)
 * Fix some issues with recursive includes handling of symbolic links, multi-root, exclusion changes, and file/folder deletion.
 * Fix unnecessary IntelliSense resetting when a new file or folder was created.
 * Fix accumulation of stale signature help and completion requests.
+* Fix some bugs with include completion.
 
 ## Version 1.21.6: August 5, 2024
 * Fix a cpptools-srv crash on shutdown. [#12354](https://github.com/microsoft/vscode-cpptools/issues/12354)

Extension/bin/messages/cs/messages.json

@@ -1410,7 +1410,7 @@
     "Striktní režim je nekompatibilní se zpracováním oboru názvů std jako aliasu pro globální obor názvů.",
     "v rozšíření makra %s %p",
     "<NEZNÁMÝ>",
-    "",
+    null,
     "[rozšíření makra %d není zobrazené]",
     "v rozšíření makra v %p",
     "neplatný název symbolického operandu %sq",
@@ -1505,7 +1505,7 @@
     "Chyba příkazového řádku",
     "vnitřní chyba",
     "Vnitřní chyba",
-    null,
+    "-D",
     null,
     "Došlo k dosažení limitu chyb.",
     "Smyčka interní chyby",
@@ -1524,7 +1524,7 @@
     "převodní jazyk (7)",
     "převodní jazyk (8)",
     "převodní jazyk (9)",
-    null,
+    "PCH",
     null,
     null,
     null,
@@ -1537,7 +1537,7 @@
     "neplatný znak pro literál char16_t",
     null,
     "Nerozpoznaná konvence volání %s, musí být jednou z:",
-    null,
+    "%s",
     null,
     null,
     "Nadřízený typ typu výčtu musí být integrální typ.",
@@ -2953,9 +2953,9 @@
     "Neplatná hodnota sady pragma %s pro funkci s omezením AMP",
     "Překrývající se specifikátory omezení nejsou povolené.",
     "Specifikátory omezení destruktoru musejí pokrývat sjednocení specifikátorů omezení všech konstruktorů.",
-    "<error>",
+    "error",
     "Pro nostdlib se vyžaduje aspoň jedno nucené použití.",
-    "<error-type>",
+    "error-type",
     null,
     null,
     null,

Extension/bin/messages/de/messages.json

@@ -1410,7 +1410,7 @@
     "Der Strict-Modus ist mit dem Behandeln des Namespaces \"std\" als Alias für den globalen Namespace inkompatibel.",
     "In Erweiterung von Makro \"%s\" %p",
     "<UNBEKANNT>",
-    "",
+    null,
     "[%d Makroerweiterungen werden nicht angezeigt.]",
     "In Makroerweiterung bei %p",
     "Ungültiger symbolischer Operandname \"%sq\".",
@@ -1505,7 +1505,7 @@
     "Befehlszeilenfehler",
     "Interner Fehler.",
     "Interner Fehler.",
-    null,
+    "-D",
     null,
     "Fehlerlimit erreicht.",
     "Interne Fehlerschleife",
@@ -1524,7 +1524,7 @@
     "Zwischensprache (7)",
     "Zwischensprache (8)",
     "Zwischensprache (9)",
-    null,
+    "PCH",
     null,
     null,
     null,
@@ -1537,7 +1537,7 @@
     "Ungültiges Zeichen für char16_t-Literal.",
     null,
     "Unbekannte Aufrufkonvention \"%s\", muss eine der folgenden Optionen sein:",
-    null,
+    "%s",
     null,
     null,
     "Der zugrunde liegende Typ des Enumerationstyps muss ein integraler Typ sein.",
@@ -2953,9 +2953,9 @@
     "Unzulässiger Wert für Pragmapaket \"%s\" für die auf AMP begrenzte Funktion.",
     "Überlappende Einschränkungsspezifizierer sind unzulässig.",
     "Die Einschränkungsspezifizierer des Destruktors müssen die Union der Einschränkungsspezifizierer für alle Konstruktoren abdecken.",
-    "<error>",
+    "Fehler",
     "Für \"nostdlib\" ist mindestens eine erzwungene Verwendung erforderlich.",
-    "<error-type>",
+    "Fehlertyp",
     null,
     null,
     null,

Extension/bin/messages/es/messages.json

@@ -1410,7 +1410,7 @@
     "el modo strict no es compatible con el trato del espacio de nombres std como alias para el espacio de nombres global",
     "en la expansión de macro '%s' %p,",
     "<DESCONOCIDO>",
-    "",
+    null,
     "[ las expansiones de macro %d no se muestran ]",
     "en expansión de macro en %p",
     "nombre de operando simbólico %sq no válido",
@@ -1505,7 +1505,7 @@
     "Error de la línea de comandos",
     "Error interno",
     "Error interno",
-    null,
+    "-D",
     null,
     "Se ha alcanzado el límite de error.",
     "Bucle de error interno",
@@ -1524,7 +1524,7 @@
     "lenguaje intermedio (7)",
     "lenguaje intermedio (8)",
     "lenguaje intermedio (9)",
-    null,
+    "PCH",
     null,
     null,
     null,
@@ -1537,7 +1537,7 @@
     "carácter no válido para el literal char16_t",
     null,
     "convención de llamada %s no reconocida, debe ser una de las siguientes:",
-    null,
+    "%s",
     null,
     null,
     "el tipo subyacente del tipo de enumeración debe ser un tipo entero",
@@ -2953,9 +2953,9 @@
     "valor de pragma pack %s no válido para la función con restricción amp",
     "no se permiten especificadores de restricción superpuestos",
     "los especificadores de restricción del destructor deben cubrir la unión de los especificadores de restricción de todos los constructores",
-    "<error>",
+    "error",
     "nostdlib requiere al menos un uso forzado",
-    "<error-type>",
+    "error-type",
     null,
     null,
     null,