Handle undefined environment variable #11480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
reviewed
Sep 28, 2023
sean-mcmanus
previously approved these changes
Sep 29, 2023
sean-mcmanus
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11447.
This fixes the processing of an environment variable in
CppProperties.resolveAndSplitandCppProperties.resolvePath.Problem:
In
util.resolvedVariable,process.envreturns undefined if an environment variable is not found or available, andutil.resolvedVariablewill return the match${env:VAR}if not resolved. The${env:VAR}will then get split and appended to other paths incorrectly and processed as if it's the variable was resolved and would lead to incorrect values for other variables or paths.Fix:
If an environment variable is not found or resolved, do not try to further change or process it.