Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job time attributes #24

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add job time attributes #24

merged 1 commit into from
Apr 29, 2024

Conversation

gerardsegarra
Copy link
Contributor

Add attributes for time and status that will be used to collect metrics.

@gerardsegarra gerardsegarra requested a review from a team April 29, 2024 11:01
Sturgelose
Sturgelose previously approved these changes Apr 29, 2024
Copy link

@Sturgelose Sturgelose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I get, we are just reserializing into our own format. So, makes sense.

Still, the __init__ and the update do mostly the same. I'm a bit blind on how they really differ or differences in use, but maybe it would be a good thought to only use one of them?

@gerardsegarra
Copy link
Contributor Author

From what I get, we are just reserializing into our own format. So, makes sense.

Still, the __init__ and the update do mostly the same. I'm a bit blind on how they really differ or differences in use, but maybe it would be a good thought to only use one of them?

The idea in the future is to do more operations in the update that are not done in the init. + the update is used to only update attributes that change after the job moves to a different status and the init is to intantiate a new object.

Base automatically changed from Add-job-event-handler to main April 29, 2024 12:34
@gerardsegarra gerardsegarra dismissed Sturgelose’s stale review April 29, 2024 12:34

The base branch was changed.

@gerardsegarra gerardsegarra merged commit afbb9a6 into main Apr 29, 2024
3 checks passed
@gerardsegarra gerardsegarra deleted the get-data-for-job branch April 29, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants