Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream/3.5.1 #46

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Merge upstream/3.5.1 #46

wants to merge 25 commits into from

Conversation

srvaroa
Copy link

@srvaroa srvaroa commented Oct 10, 2023

  • Kafka manager with web UI to monitor and maintain Kafka's clusters
  • configured max-old-space-size for js-executor
  • typo
  • added max-old-space-size for web-ui
  • Version set to 3.4.2
  • Version set to 3.4.3
  • add tb-edge-loadbalancer
  • fix http transport bind port for load-balancer
  • Delete the TRANSPORT_TYPE variable as unused
  • Added upgrade launch script
  • Release 3.4.4
  • Version set to 3.5.0
  • gcp edge load balancer for monolith
  • Added AWS and Azure Edge load balancer receipts
  • Increase Kafka logs volume size to 10Gi
  • Version set to 3.5.1

smatvienko-tb and others added 25 commits June 3, 2021 12:54
…ovements

[3.4.2] configured max-old-space-size for js-executor
[3.4.2] added max-old-space-size for web-ui
fix http transport bind port for load-balancer
…grade-tb-script

Added upgrade launch script
Delete the TRANSPORT_TYPE variable as unused
Kafka manager with web UI to monitor and maintain Kafka's clusters
…ncer

Edge LoadBalancer services for GCP, AWS, Azure k8s deployments
* upstream/release-3.5.1:
  Version set to 3.5.1
  Increase Kafka logs volume size to 10Gi
  Added AWS and Azure Edge load balancer receipts
  gcp edge load balancer for monolith
  Version set to 3.5.0
  Release 3.4.4
  Added upgrade launch script
  Delete the TRANSPORT_TYPE variable as unused
  fix http transport bind port for load-balancer
  add tb-edge-loadbalancer
  Version set to 3.4.3
  Version set to 3.4.2
  added max-old-space-size for web-ui
  typo
  configured max-old-space-size for js-executor
  Kafka manager with web UI to monitor and maintain Kafka's clusters
@srvaroa srvaroa requested review from xavileon and a team October 10, 2023 10:42
Copy link

@xavileon xavileon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, we only use helm though, so most of the updates will remain unused.

@xavileon
Copy link

on second thought, we diverted so much from upstream, that maybe it's better to remove all directories except helm to clean up what is not really used?

@srvaroa
Copy link
Author

srvaroa commented Oct 10, 2023

I am kind of sympathetic to removing the unused stuff, BUT, that means we automatically force us to a hard-fork of the chart, and keeping things up to date will be a lot harder.

It seems simpler to me to just be disciplined keeping our fork up to date with upstream. If there are updates that are not relevant to us that's harmless. But we ensure that we remain aligned with upstream releases.

@maht
Copy link

maht commented Oct 10, 2023

I am kind of sympathetic to removing the unused stuff, BUT, that means we automatically force us to a hard-fork of the chart, and keeping things up to date will be a lot harder.

It seems simpler to me to just be disciplined keeping our fork up to date with upstream. If there are updates that are not relevant to us that's harmless. But we ensure that we remain aligned with upstream releases.

At the beginning I agreed in thinking it was easier to just maintain it, but I think we should somehow put a disclaimer in the README about the fact that Midokura changes are only tested with Helm, and the other providers are probably not updated and/or usable.

Otherwise a newcomer could spent to much time before realize that they are basically broken and we only kept them to make sync with upstream easier.

@srvaroa
Copy link
Author

srvaroa commented Oct 10, 2023

I don't think that the default reasonable assumption from a random internet person that finds this fork is that we're actually supporting the whole thing, but random internet people is not famous for being reasonable, so yes, a disclaimer might be a good idea!

@xavileon
Copy link

xavileon commented Oct 10, 2023

It seems simpler to me to just be disciplined keeping our fork up to date with upstream. If there are updates that are not relevant to us that's harmless. But we ensure that we remain aligned with upstream releases.

Sounds reasonable! Let's look in EVP how to be disciplined in keeping this fork up to date 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.