Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS tweaks, initial templates, link fixer script, tree struct preparation #5

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

CSS tweaks, initial templates, link fixer script, tree struct preparation #5

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
69e44c0
css: less contrasted alternating table line backgrounds
ElementW Sep 29, 2024
a8d49e9
css: change dark table border to match contrast level of light
ElementW Sep 29, 2024
97e0741
css: reduce table padding
ElementW Sep 29, 2024
f724a9e
Rework render-link to support tree structure
ElementW Sep 29, 2024
e727258
Add "View in git" link at bottom
ElementW Sep 29, 2024
b1e0b4c
Main page: make banner color work in dark mode
ElementW Sep 29, 2024
444fd12
Add ipc, kernel object and struct templates
ElementW Sep 29, 2024
65212ee
Emit warnings instead of errors when reflinks are not found
ElementW Sep 29, 2024
49d5ec8
Prepare _index.md's for tree structure
ElementW Sep 29, 2024
7f583f4
Make hugo-book menu index from select directories
ElementW Sep 29, 2024
faf20bb
Add a .gitignore
ElementW Sep 29, 2024
ee0dba9
Add link updater script
ElementW Sep 29, 2024
6942adb
Apply link updater
ElementW Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion assets/_custom.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,27 @@
/* You can add custom styles here. */

// @import "plugins/numbered";
// @import "plugins/scrollbars";

:root {
--gray-50: #fafbfc;
--table-2n-background: var(--gray-100);
}
@media(prefers-color-scheme: dark) {
:root {
--gray-50: rgba(255, 255, 255, 0.05);
--table-2n-background: var(--gray-50);
}
}

.container {
max-width: 100rem
max-width: 100rem;
}

.markdown {
table tr {
&:nth-child(2n) {
background: var(--table-2n-background);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about this. Alternating row colors are really useful on large tables (such as the title list). However for smaller tables and for sequential structures like IPC command tables, non-alternating colors are the right choice indeed. Is there a way we could opt into alternating row colors for individual tables that benefit from it (without forcing those tables to be HTML)?

Doesn't need to happen now, just curious if we could support both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, just to double-check: Was the intent here indeed to disable alternating row colors, or is this an unintended effect for the light theme?

Copy link
Contributor Author

@ElementW ElementW Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not an unintended effect, the default book theme has alternating colors, but as usual with people that have very little design and color theory, both are offset a fixed number of RGB units from the background color, which results in a very different effect between light and dark themes because of the human eyes' nonlinear sensitivity.

This is just here to fix that, but the point about being opt-in is a good one, although I have no idea on how to make this fit in nicely with Markdown, is there a way to specify table classes in this dialect?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to specify table classes in this dialect?

Doesn't seem like it, but goldmark has no problem with wrapping the entire markdown table in a <div>. So we can just do that and then define a CSS rule for .withalternatingrows > table > ... :)

}