Add compatibility with guzzle 6.3.0 #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TJSoler, absolutely. I haven't had any time recently to work on this project (I was using it on a side-project that didn't go anywhere). I'm open to dropping support for the old Guzzle client in favour of the latest. |
|
I can rework this PR into dropping support for old guzzle, setting this up as a default (with examples and readme updates) and setting up travis to check on 5.5+. We can start from there if you like. |
|
Hi @TJSoler - i'm looking to use this library in a PHP 7.2 environment at the moment... happy to help to test/continue development on this branch. What's the best way for me to get this fork via composer? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't modified the composer file, but as guzzle 6.3.0 requires PHP 5.5, this adapter will break without that version of PHP.
Besides that, I'm going to be using this library pretty extensively for the next couple of months, would you be open to a modernization of the code? I would try to create some PRs to move to PHP 7.x, write some tests, clean the methods a little, etc.