Multi-GPU friendly data processing. #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marondeau-mila
commented
Jan 26, 2023
marondeau-mila
commented
- Split the download and the loading.
- In general, separated the processing into functions that can be called independently
-
- For example, to create the split once, and reload it as needed.
- Also tried to do some light refactoring to simplify customization.
Also, class with only static methods should be replaced by module.
| @@ -77,8 +75,16 @@ def evaluate(args, data_dir, hyper_params): | |||
| ['architecture', 'batch_size', 'exp_name', 'early_stopping'], | |||
| hyper_params) | |||
|
|
|||
| if torch.cuda.is_available(): | |||
There was a problem hiding this comment.
@jerpint / @plstcharles / @hbertrand : just a request for comment here - here we use CUDA_VISIBLE_DEVICE environment variable to control which gpu to use. Do you think this is clear enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.