Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/reduce bundle size #453

Open
wants to merge 8 commits into
base: v1-migration
Choose a base branch
from

Conversation

gregdolby
Copy link

  • Removed 'joi'
  • created custom publish options validation (our joi validation wasn't doing much in the first place, just warnings. all undefined properties would be validated)
  • added tests for custom validation
  • removed excess bundled files. only es module build with types exists now

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: bca3907

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gregdolby
Copy link
Author

I am working through this e2e test failure and it has to do with the build output. Puppeteer needs umd build but I am trying to figure out how to get it to work with es module bundle.

@gregdolby
Copy link
Author

I ended up adding umd bundle back. Jest tests and puppeteer run in node and they both support esm but for jest it is experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants