Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Publisher demo app to TypeScript #461

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

juanpiquerez
Copy link
Contributor

Demo apps should be converted to TypeScript and work as expected

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 2ab7676

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juanpiquerez juanpiquerez marked this pull request as ready for review October 22, 2024 19:21
Copy link
Contributor

@Santiago-Souto Santiago-Souto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Santiago-Souto Santiago-Souto merged commit 5ca10a3 into v1-migration Oct 23, 2024
4 checks passed
@Santiago-Souto Santiago-Souto deleted the migrate_demo_apps_to_typescript branch October 23, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants