Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setSimulcast function #467

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove setSimulcast function #467

merged 1 commit into from
Oct 29, 2024

Conversation

juanpiquerez
Copy link
Contributor

Simulcast is currently supported on Chrome only, change this behaviour so that it works on all browsers

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 3ee3dc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juanpiquerez juanpiquerez marked this pull request as ready for review October 25, 2024 19:23
Santiago-Souto
Santiago-Souto approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@Santiago-Souto Santiago-Souto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanpiquerez juanpiquerez merged commit aba0bc1 into v1-migration Oct 29, 2024
4 checks passed
@juanpiquerez juanpiquerez deleted the support_simulcast_on_all_browsers branch October 29, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubeyShivank dubeyShivank dubeyShivank approved these changes

@Santiago-Souto Santiago-Souto Santiago-Souto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanpiquerez @Santiago-Souto @dubeyShivank