Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Add mdspan API to raft IVF functions #810

Merged
merged 6 commits into from
May 5, 2023

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Apr 12, 2023

This PR changes the raft ivf function calls from raw pointer to mdspan. These functions are pre-compiled in libraft so it will speed up the compile time.

To receive the latest libraft release, it is recommended to use conda package manager:

conda install -c rapidsai -c nvidia -c rapidsai-nightly libraft==23.04.00a

I'm open for suggestions on how to handle installing conda and linking to libraft.
issue: #857

@sre-ci-robot
Copy link

Welcome @lowener! It looks like this is your first PR to milvus-io/knowhere 🎉

@mergify mergify bot added needs-dco DCO is missing in this pull request. do-not-merge/missing-related-issue labels Apr 12, 2023
@mergify
Copy link

mergify bot commented Apr 12, 2023

@lowener Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@Presburger
Copy link
Collaborator

This PR changes the raft ivf function calls from raw pointer to mdspan. These functions are pre-compiled in libraft so it will speed up the compile time.

To receive the latest libraft release, it is recommended to use conda package manager:

conda install -c rapidsai -c nvidia -c rapidsai-nightly libraft==23.04.00a

I'm open for suggestions on how to handle installing conda and linking to libraft.

thanks for contribute the code,
is it heavily dependent on to the conda?

@lowener
Copy link
Contributor Author

lowener commented Apr 14, 2023

Conda is the preferred way to get libraft usually. Since conda is not being used right now I found an alternative with pip through the pylibraft package.

Signed-off-by: Mickael Ide <[email protected]>
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 14, 2023
@Presburger
Copy link
Collaborator

@lowener Essentially, we are using knowhere more as a c++ library, and if he needs to rely on the python environment, it will be troublesome for us in the vast majority of cases.

@Presburger
Copy link
Collaborator

@lowener This pr is excellent and I would accept it if you remove the HINT_LIBRAFT related code. thank you.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Apr 21, 2023
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 21, 2023
Signed-off-by: Mickael Ide <[email protected]>
@mergify mergify bot added the ci-passed label May 5, 2023
@Presburger
Copy link
Collaborator

/lgtm

@Presburger
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lowener, Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 743bb3e into milvus-io:main May 5, 2023
@lowener lowener deleted the fea-mdspan-raft branch May 5, 2023 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants