-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add PreallocatedSegmentIDs for the compaction task #36734
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: bigsheeper <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: bigsheeper <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36734 +/- ##
==========================================
- Coverage 82.41% 73.32% -9.10%
==========================================
Files 1299 1299
Lines 153065 153071 +6
==========================================
- Hits 126154 112232 -13922
- Misses 21841 35774 +13933
+ Partials 5070 5065 -5
|
/lgtm |
Add
PreallocatedSegmentIDs
field to the compaction task, allowing theResultSegments
in the compaction task to represent the final segments produced by the compaction.issue: #36733
also related: #36686