Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add PreallocatedSegmentIDs for the compaction task #36734

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

Add PreallocatedSegmentIDs field to the compaction task, allowing the ResultSegments in the compaction task to represent the final segments produced by the compaction.

issue: #36733

also related: #36686

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 10, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 10, 2024
@mergify mergify bot added the ci-passed label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.32%. Comparing base (a5f98e4) to head (b2b9af9).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/compaction_task_meta.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36734      +/-   ##
==========================================
- Coverage   82.41%   73.32%   -9.10%     
==========================================
  Files        1299     1299              
  Lines      153065   153071       +6     
==========================================
- Hits       126154   112232   -13922     
- Misses      21841    35774   +13933     
+ Partials     5070     5065       -5     
Files with missing lines Coverage Δ
internal/datacoord/compaction_task_clustering.go 78.65% <100.00%> (-0.16%) ⬇️
internal/datacoord/compaction_task_mix.go 62.16% <100.00%> (+0.38%) ⬆️
internal/datacoord/compaction_trigger.go 85.16% <100.00%> (+0.23%) ⬆️
internal/datacoord/compaction_trigger_v2.go 58.98% <ø> (ø)
internal/datacoord/compaction_task_meta.go 77.50% <0.00%> (-4.08%) ⬇️

... and 250 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants