Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] allign orientation train script to current orientation model (counter clockwise instead of clockwise) & make OrientationPredictor dynamic #1559

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • Allign orientation train scripts to current model behavior (counter clockwise instead of clockwise - fix labels)
  • change to general OrientationPredictor (for crop and page orientation models)

@felixdittrich92 felixdittrich92 added type: bug Something isn't working type: enhancement Improvement module: models Related to doctr.models ext: references Related to references folder topic: character classification Related to the task of character classification labels Apr 19, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone Apr 19, 2024
@felixdittrich92 felixdittrich92 self-assigned this Apr 19, 2024
@odulcy-mindee odulcy-mindee merged commit 0285711 into mindee:main Apr 19, 2024
67 of 68 checks passed
"url": "https://doctr-static.mindee.com/models?id=v0.4.1/classif_mobilenet_v3_small-24f8ff57.pt&src=0",
},
"mobilenet_v3_small_page_orientation": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to expose it in zoo.py no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct later on i added only the additional dict ftm that you have a place to put the url :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test integration etc then let n #1553

@felixdittrich92 felixdittrich92 deleted the fix-orient branch April 19, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder module: models Related to doctr.models topic: character classification Related to the task of character classification type: bug Something isn't working type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants