-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable page and crop orientation #1735
Disable page and crop orientation #1735
Conversation
Disable orient prototype
…troid more verbose variable names
Hi @milosacimovic 👋 |
API test fail is fine will success after merge |
@milosacimovic Could you fix the mypy issue please https://github.com/mindee/doctr/actions/runs/11067610457/job/30751370517?pr=1735 |
Overwrites: #1723 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 164 164
Lines 7782 7817 +35
=======================================
+ Hits 7502 7536 +34
- Misses 280 281 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…er get executed when model is none for orientation classification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milosacimovic
LGTM now 👍
Really nice and useful feature 🥳
CC @nikokks
Should also speed up processing a lot :) |
Hi @felixdittrich92 ,
I've merged your changes from disable orient prototype and slightly modified the function extract_rcrops which works better according to some of my internal tests.