Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] update minor version & update torch to >= 2.0 #1747

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Oct 8, 2024

This PR:

  • change to 0.10 for next release (already a lot of minor stuff added since 0.9.0 so next is not a patch release)
  • I think it's time to move to pytorch >= 2.0 (already close before 2.5) ^^

Any feeback is welcome 🤗

PS: Afterwards i would update all related issues / tracker / etc.
PSS: labeled as breaking change that we don't miss to mention in the next release notes :)

@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build type: breaking change Introducing a breaking change type: misc Miscellaneous labels Oct 8, 2024
@felixdittrich92 felixdittrich92 added this to the 0.10.0 milestone Oct 8, 2024
@felixdittrich92 felixdittrich92 self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (59f1c30) to head (f583057).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
+ Coverage   96.46%   96.48%   +0.01%     
==========================================
  Files         164      164              
  Lines        7869     7881      +12     
==========================================
+ Hits         7591     7604      +13     
+ Misses        278      277       -1     
Flag Coverage Δ
unittests 96.48% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@felixdittrich92 felixdittrich92 merged commit 7f21e76 into mindee:main Oct 10, 2024
82 checks passed
@felixdittrich92 felixdittrich92 deleted the version-and-torch branch October 10, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to dependencies and build type: breaking change Introducing a breaking change type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants