Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 typing with py310 Union | #225

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: 🐛 typing with py310 Union | #225

merged 1 commit into from
Nov 12, 2024

Conversation

bashirmindee
Copy link
Collaborator

Description

Fixes issue when ExecNode's return type has |

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@Mattcrmx Mattcrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you add a comment below in the source ode so that we lnow whch case it refers to ?

@bashirmindee
Copy link
Collaborator Author

@Mattcrmx you can look at the tests here: tests/test_multiple_return_value_for_exec_node.py:225

@bashirmindee bashirmindee merged commit b2cfc37 into main Nov 12, 2024
17 checks passed
@bashirmindee bashirmindee deleted the quick-fix branch November 12, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants