AT Overhaul #2365
Open
AT Overhaul #2365
+2,226
−481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolved all the highlighting weirdnesses happening while editing ATs, like whole entries being red while correct Also adds a recovery rule for keywords and only use consumeTokenFast for recovery rules, to show users what is wrong with their syntax
AtGotoDeclarationHandler is replaced by proper PsiReferences
They no longer use SRG for member names
Removed redundant code and fixes some false positives
Also fixes AtParserDefinition#spaceExistenceTypeBetweenTokens
Also fixes initial entry indent being 8 spaces instead of none
RedNesto
force-pushed
the
at-overhaul
branch
from
f556e77
to
f53706e
Compare
DenWav
reviewed
Sep 22, 2024
| } | ||
|
|
||
| private fun isSuppressing(entryComment: String, toolId: String): Boolean { | ||
| val suppressed = entryComment.substringAfter("Suppress:").substringBefore(' ').split(',') |
There was a problem hiding this comment.
To follow the IntelliJ standard shouldn't this look for noinspecetion?
There was a problem hiding this comment.
I don't think there's a standard, the Properties plugin uses suppress as a keyword too.
| override fun getText(): @IntentionName String = when (startElement) { | ||
| is AtEntry -> "Suppress $toolId for entry" | ||
| is AtFile -> "Suppress $toolId for file" | ||
| else -> "Suppress $toolId" |
There was a problem hiding this comment.
Is there an option to suppress an individual entry inspection for the whole file? Or am I just not reading this right?
There was a problem hiding this comment.
The fix supports both file-level and entry-level suppressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2371, fixes #219, fixes #183