MAN-28 - update seconday text for lc note where no user has been reco… #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marcus-bcl
approved these changes
Oct 17, 2024
| {% if lcNote.createdBy %} | ||
| <p class="govuk-body-s secondary-text">Comment added by {{ lcNote.createdBy }} on {{ lcNote.createdByDate | dateWithYear }}</p> | ||
| {% else %} | ||
| <p class="govuk-body-s secondary-text">Comment added by not entered</p> |
There was a problem hiding this comment.
Would it be better to just hide this text if we don't have the user/date? Might be worth checking with the designers?
There was a problem hiding this comment.
will check with them. i did set to hide the text, but with some notes with the secondary text and some without, i thought it looked a bit wierd
achimber-moj
deleted the
MAN-28-sentence-license-condition-notes-no-created-by
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rded