AP-5335: Remove housing_benefit_regular_transaction_applicable

Distinctinction between truelayer and bank statement upload journey no longer applicable so may as well shortcut it.
ministryofjustice · Oct 16, 2024 · 2697d02 · 2697d02
1 parent 1de8e39
commit 2697d02
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/app/models/legal_aid_application.rb b/app/models/legal_aid_application.rb
@@ -611,10 +611,6 @@ def housing_payments_for?(party)
     TransactionType.where(id: owners_transaction_types).for_outgoing_type?(:rent_or_mortgage)
   end
 
-  def housing_benefit_regular_transaction_applicable?
-    housing_payments?
-  end
-
   def truelayer_path?
     provider_received_citizen_consent == true
   end

diff --git a/app/views/providers/means/check_income_answers/show.html.erb b/app/views/providers/means/check_income_answers/show.html.erb
@@ -10,7 +10,7 @@
 
   <%= render "providers/means/check_income_answers/partner_income_assessment" if @legal_aid_application.applicant.has_partner_with_no_contrary_interest? %>
 
-  <% if @legal_aid_application.housing_benefit_regular_transaction_applicable? %>
+  <% if @legal_aid_application.housing_payments? %>
     <%= render(
           "shared/check_answers/housing_benefit",
           read_only: false,

diff --git a/.../shared/review_application/_income_payments_and_assets_for_bank_statement_upload.html.erb b/.../shared/review_application/_income_payments_and_assets_for_bank_statement_upload.html.erb
@@ -106,7 +106,7 @@
 <!-- HOUSING BENEFIT -->
 
   <section class="print-no-break">
-    <% if @legal_aid_application.housing_benefit_regular_transaction_applicable? %>
+    <% if @legal_aid_application.housing_payments? %>
       <% individual = @legal_aid_application.applicant.has_partner_with_no_contrary_interest? ? t("generic.client_or_partner") : t("generic.client") %>
       <%= render(
             "shared/check_answers/housing_benefit",